feat: achieve 100% test coverage with story detection and timeout handling

- Add has_story() function to detect forwarded stories in anti-spam checks
- Integrate story detection into handle_new_user_spam violation logic
- Add comprehensive tests for story detection (TestHasStory)
- Add urlparse exception handling test in TestUrlWhitelist
- Add test case for messages with shared stories (test_deletes_message_with_story)
- Add check_command_complete_profile_whitelisted test with unverify button
- Add timeout handling tests for check, check_forwarded, and warn_callback
- Import TimedOut exception from telegram.error for error handling
- Update README test coverage metrics: 99% → 100% (1,181 statements)
- Update test count: 328 → 336 tests (all passing)
- Update handler coverage: anti_spam.py 98% → 100%, check.py 95% → 100%

All modules now achieve 100% code coverage with complete error handling and edge case testing for the Telegram bot's profile verification, captcha, and anti-spam protection systems.

Author: rezhajulio

README.md

@@ -150,12 +150,12 @@ uv run pytest -v
 ### Test Coverage
 
 The project maintains comprehensive test coverage:
-- **Coverage**: 99% (1,179 statements, 9 missed)
-- **Tests**: 328 total
-- **Pass Rate**: 100% (328/328 passed)
-- **All modules**: 99% coverage including JobQueue scheduler integration, captcha verification, and anti-spam enforcement
+- **Coverage**: 100% (1,181 statements)
+- **Tests**: 336 total
+- **Pass Rate**: 100% (336/336 passed)
+- **All modules**: 100% coverage including JobQueue scheduler integration, captcha verification, and anti-spam enforcement
   - Services: `bot_info.py` (100%), `scheduler.py` (100%), `user_checker.py` (100%), `telegram_utils.py` (100%), `captcha_recovery.py` (100%)
-  - Handlers: `anti_spam.py` (98%), `captcha.py` (100%), `check.py` (95%), `dm.py` (100%), `message.py` (100%), `topic_guard.py` (100%), `verify.py` (100%)
+  - Handlers: `anti_spam.py` (100%), `captcha.py` (100%), `check.py` (100%), `dm.py` (100%), `message.py` (100%), `topic_guard.py` (100%), `verify.py` (100%)
   - Database: `service.py` (100%), `models.py` (100%)
   - Config: `config.py` (100%)
   - Constants: `constants.py` (100%)

src/bot/handlers/anti_spam.py

@@ -76,6 +76,21 @@ def has_external_reply(message: Message) -> bool:
     return message.external_reply is not None
 
 
+def has_story(message: Message) -> bool:
+    """
+    Check if a message contains a forwarded story.
+
+    Stories can be shared/forwarded into chats and may be used as a spam vector.
+
+    Args:
+        message: Telegram message to check.
+
+    Returns:
+        bool: True if message contains a story.
+    """
+    return message.story is not None
+
+
 def extract_urls(message: Message) -> list[str]:
     """
     Extract all URLs from a message.
@@ -218,13 +233,13 @@ async def handle_new_user_spam(
     user_mention = get_user_mention(user)
 
     # Check for violations (forwarded message or non-whitelisted link or external reply)
-    if not (is_forwarded(msg) or has_non_whitelisted_link(msg) or has_external_reply(msg)):
+    if not (is_forwarded(msg) or has_non_whitelisted_link(msg) or has_external_reply(msg) or has_story(msg)):
         return  # Not a violation
 
     logger.info(
         f"Probation violation detected: user_id={user.id}, "
         f"forwarded={is_forwarded(msg)}, has_non_whitelisted_link={has_non_whitelisted_link(msg)}, "
-        f"external_reply={has_external_reply(msg)}"
+        f"external_reply={has_external_reply(msg)}, has_story={has_story(msg)}"
     )
 
     # 1. Delete the violating message

tests/test_anti_spam.py

@@ -12,6 +12,7 @@
     has_external_reply,
     has_link,
     has_non_whitelisted_link,
+    has_story,
     is_forwarded,
     is_url_whitelisted,
 )
@@ -109,6 +110,24 @@ def test_no_external_reply_returns_false(self):
         assert has_external_reply(msg) is False
 
 
+class TestHasStory:
+    """Tests for the has_story helper function."""
+
+    def test_story_detected(self):
+        """Test that message with story is detected."""
+        msg = MagicMock(spec=Message)
+        msg.story = MagicMock()  # Any non-None value indicates a shared story
+
+        assert has_story(msg) is True
+
+    def test_no_story_returns_false(self):
+        """Test that message without story returns False."""
+        msg = MagicMock(spec=Message)
+        msg.story = None
+
+        assert has_story(msg) is False
+
+
 class TestUrlWhitelist:
     """Tests for URL whitelist functionality."""
 
@@ -171,6 +190,11 @@ def test_malformed_url_exception_handled(self):
         # This URL has an invalid character that may cause parsing issues
         assert is_url_whitelisted("\x00invalid") is False
 
+    def test_urlparse_exception_returns_false(self):
+        """Test that exceptions during URL parsing return False."""
+        with patch("bot.handlers.anti_spam.urlparse", side_effect=ValueError("parse error")):
+            assert is_url_whitelisted("https://github.com/user/repo") is False
+
 
 class TestExtractUrls:
     """Tests for URL extraction."""
@@ -274,9 +298,10 @@ def mock_update(self):
         update.effective_chat = MagicMock(spec=Chat)
         update.effective_chat.id = -100123456  # group_id from settings
 
-        # Default: not forwarded, no links, no external reply
+        # Default: not forwarded, no links, no external reply, no story
         update.message.forward_origin = None
         update.message.external_reply = None
+        update.message.story = None
         update.message.entities = None
         update.message.caption_entities = None
         update.message.text = None
@@ -621,6 +646,31 @@ async def test_deletes_message_with_external_reply(
 
         mock_update.message.delete.assert_called_once()
 
+    @pytest.mark.asyncio
+    async def test_deletes_message_with_story(
+        self, mock_update, mock_context, mock_settings
+    ):
+        """Test that messages with shared stories are deleted."""
+        mock_update.message.story = MagicMock()  # Any non-None value
+
+        mock_record = MagicMock()
+        mock_record.joined_at = datetime.now(UTC)
+
+        updated_record = MagicMock()
+        updated_record.violation_count = 1
+
+        mock_db = MagicMock()
+        mock_db.get_new_user_probation.return_value = mock_record
+        mock_db.increment_new_user_violation.return_value = updated_record
+
+        with (
+            patch("bot.handlers.anti_spam.get_settings", return_value=mock_settings),
+            patch("bot.handlers.anti_spam.get_database", return_value=mock_db),
+        ):
+            await handle_new_user_spam(mock_update, mock_context)
+
+        mock_update.message.delete.assert_called_once()
+
     @pytest.mark.asyncio
     async def test_ignores_update_without_message(self, mock_context, mock_settings):
         """Test that update without message is ignored."""

tests/test_check.py

@@ -3,6 +3,7 @@
 from unittest.mock import AsyncMock, MagicMock, patch
 
 import pytest
+from telegram.error import TimedOut
 
 from bot.handlers.check import (
     handle_check_command,
@@ -116,6 +117,39 @@ async def test_check_command_complete_profile(
         assert "✅" in call_args.args[0]
         assert call_args.kwargs.get("reply_markup") is None
 
+    async def test_check_command_complete_profile_whitelisted(
+        self, mock_update, mock_context, mock_settings
+    ):
+        """Shows complete profile with unverify button when user is whitelisted."""
+        mock_context.args = ["555666"]
+
+        complete_result = ProfileCheckResult(
+            has_profile_photo=True, has_username=True
+        )
+
+        mock_db = MagicMock()
+        mock_db.is_user_photo_whitelisted.return_value = True
+
+        with (
+            patch("bot.handlers.check.get_settings", return_value=mock_settings),
+            patch(
+                "bot.handlers.check.check_user_profile",
+                return_value=complete_result,
+            ),
+            patch("bot.handlers.check.get_database", return_value=mock_db),
+        ):
+            await handle_check_command(mock_update, mock_context)
+
+        mock_update.message.reply_text.assert_called_once()
+        call_args = mock_update.message.reply_text.call_args
+        assert "555666" in call_args.args[0]
+        assert "✅" in call_args.args[0]
+        keyboard = call_args.kwargs.get("reply_markup")
+        assert keyboard is not None
+        buttons = keyboard.inline_keyboard[0]
+        assert any("unverify:555666" in btn.callback_data for btn in buttons)
+        assert any("Unverify User" in btn.text for btn in buttons)
+
     async def test_check_command_incomplete_profile(
         self, mock_update, mock_context, mock_settings
     ):
@@ -187,6 +221,17 @@ async def test_check_command_get_chat_error(self, mock_update, mock_context):
         call_args = mock_update.message.reply_text.call_args
         assert "Gagal memeriksa" in call_args.args[0]
 
+    async def test_check_command_timeout(self, mock_update, mock_context):
+        """Handles TimedOut error gracefully."""
+        mock_context.args = ["555666"]
+        mock_context.bot.get_chat.side_effect = TimedOut()
+
+        await handle_check_command(mock_update, mock_context)
+
+        mock_update.message.reply_text.assert_called_once()
+        call_args = mock_update.message.reply_text.call_args
+        assert "timeout" in call_args.args[0].lower()
+
 
 class TestHandleCheckForwardedMessage:
     async def test_check_forwarded_non_admin(self, mock_update, mock_context):
@@ -308,6 +353,21 @@ async def test_check_forwarded_error(self, mock_update, mock_context, mock_setti
         call_args = mock_update.message.reply_text.call_args
         assert "Gagal memeriksa" in call_args.args[0]
 
+    async def test_check_forwarded_timeout(self, mock_update, mock_context):
+        """Handles TimedOut error gracefully."""
+        forwarded_user = MagicMock()
+        forwarded_user.id = 555666
+        forwarded_user.full_name = "Forwarded User"
+        mock_update.message.forward_from = forwarded_user
+
+        mock_context.bot.get_chat.side_effect = TimedOut()
+
+        await handle_check_forwarded_message(mock_update, mock_context)
+
+        mock_update.message.reply_text.assert_called_once()
+        call_args = mock_update.message.reply_text.call_args
+        assert "timeout" in call_args.args[0].lower()
+
 
 class TestHandleWarnCallback:
     async def test_warn_callback_non_admin(self, mock_context):
@@ -453,3 +513,27 @@ async def test_warn_callback_send_message_error(self, mock_context, mock_setting
         query.edit_message_text.assert_called_once()
         call_args = query.edit_message_text.call_args
         assert "Gagal mengirim" in call_args.args[0]
+
+    async def test_warn_callback_timeout(self, mock_context, mock_settings):
+        """Handles TimedOut error gracefully."""
+        update = MagicMock()
+        query = MagicMock()
+        query.from_user = MagicMock()
+        query.from_user.id = 12345
+        query.from_user.full_name = "Admin User"
+        query.data = "warn:555666:pu"
+        query.answer = AsyncMock()
+        query.edit_message_text = AsyncMock()
+        update.callback_query = query
+
+        mock_chat = MagicMock()
+        mock_chat.full_name = "Test User"
+        mock_context.bot.get_chat.return_value = mock_chat
+        mock_context.bot.send_message.side_effect = TimedOut()
+
+        with patch("bot.handlers.check.get_settings", return_value=mock_settings):
+            await handle_warn_callback(update, mock_context)
+
+        query.edit_message_text.assert_called_once()
+        call_args = query.edit_message_text.call_args
+        assert "timeout" in call_args.args[0].lower()