feat: further modernize codebase (ui/app-vite/cli/...everything)

Author: rstoenescu

.oxlintrc.json

@@ -20,10 +20,12 @@
     "extras/themify/",
 
     "ui/icon-set/svg-*.js",
-    "ui/lang/index.json"
+    "ui/lang/index.json",
+
+    "utils/render-ssr-error/compiled-assets/"
   ],
 
-  "plugins": ["vue", "import", "eslint"],
+  "plugins": ["vue", "import", "eslint", "promise", "vue", "unicorn"],
 
   "categories": {
     "style": "error",
@@ -82,6 +84,14 @@
     "eslint/arrow-body-style": ["error", "as-needed"],
     "vue/define-props-destructuring": "off",
     "vue/define-props-declaration": "off",
+    "promise/avoid-new": "off",
+    "promise/param-names": "off",
+    "promise/prefer-await-to-callbacks": "off",
+    "promise/prefer-await-to-then": "off",
+    "unicorn/no-nested-ternary": "off",
+    "unicorn/no-null": "off",
+    "unicorn/filename-case": "off",
+    "unicorn/prefer-global-this": "off",
 
     /** Performance rule overrides */
     "no-await-in-loop": "off",
@@ -95,6 +105,8 @@
     "no-useless-concat": "off",
     "require-post-message-target-origin": "off",
     "no-this-in-exported-function": "off",
+    "promise/always-return": "off",
+    "promise/no-promise-in-callback": "off",
 
     /** Correctness rule overrides */
     "no-unused-vars": [
@@ -103,6 +115,7 @@
         "ignoreRestSiblings": true
       }
     ],
+    "promise/no-callback-in-promise": "off",
 
     /** Restriction rule overrides */
     "no-void": "off",
@@ -122,6 +135,11 @@
     "import/no-default-export": "off",
     "import/no-dynamic-require": "off",
     "import/unambiguous": "off",
+    "promise/catch-or-return": "off",
+    "unicorn/no-process-exit": "off",
+    "unicorn/no-array-for-each": "off",
+    "unicorn/no-array-reduce": "off",
+    "unicorn/no-abusive-eslint-disable": "off",
 
     /** Pedantic rule overrides */
     "unicorn/explicit-length-check": [
@@ -138,7 +156,9 @@
     "max-lines-per-function": "off",
     "max-classes-per-file": "off",
     "sort-vars": "off",
-    "import/max-dependencies": "off"
+    "import/max-dependencies": "off",
+    "unicorn/no-array-callback-reference": "off",
+    "unicorn/prefer-query-selector": "off"
   },
 
   "overrides": [
@@ -151,17 +171,34 @@
     },
 
     {
-      "files": ["{app-vite,cli,create-quasar,extras,icongenie,app-webpack}/**"],
+      "files": ["{app-vite,cli,create-quasar,icongenie}/**"],
+      "env": {
+        "node": true
+      },
+      "plugins": ["node"],
+      "rules": {
+        "import/first": "off",
+        "node/no-process-env": "off"
+      }
+    },
+
+    {
+      "files": ["{extras,app-webpack}/**"],
       "env": {
         "node": true
       },
+      "plugins": ["node"],
       "rules": {
-        "import/first": "off"
+        "import/first": "off",
+        "node/global-require": "off",
+        "node/no-process-env": "off",
+        "unicorn/prefer-module": "off",
+        "unicorn/prefer-top-level-await": "off"
       }
     },
 
     {
-      "files": ["ui/src/**/*.js"],
+      "files": ["ui/src/**"],
       "globals": {
         "__QUASAR_VERSION__": "readonly",
         "__QUASAR_SSR__": "readonly",
@@ -184,7 +221,8 @@
         "**/*.cjs"
       ],
       "rules": {
-        "no-commonjs": "off"
+        "no-commonjs": "off",
+        "unicorn/prefer-module": "off"
       }
     },
 

app-vite/exports/bex/private/bex-bridge.js

@@ -350,7 +350,7 @@ export class BexBridge {
   log(...args) {
     if (this.#debug !== true || args.length === 0) return
 
-    const lastArg = args[args.length - 1]
+    const lastArg = args.at(-1)
 
     if (lastArg !== void 0 && Object(lastArg) === lastArg) {
       const log = `${this.#banner} ${args.slice(0, -1).join(' ')} (click to expand)`
@@ -365,7 +365,7 @@ export class BexBridge {
   warn(...args) {
     if (args.length === 0) return
 
-    const lastArg = args[args.length - 1]
+    const lastArg = args.at(-1)
 
     if (lastArg !== void 0 && Object(lastArg) === lastArg) {
       console.warn(this.#banner, ...args.slice(0, -1))
@@ -418,7 +418,8 @@ export class BexBridge {
     )
 
     let responsePayload
-    for (const { type, callback } of list.slice(0)) {
+    // oxlint-disable-next-line unicorn/no-useless-spread
+    for (const { type, callback } of [...list]) {
       if (type === 'once') {
         this.off(message.event, callback)
       }
@@ -669,6 +670,7 @@ export class BexBridge {
     }
 
     return promise.catch(err => {
+      // oxlint-disable-next-line promise/no-nesting
       this.#sendPacket({
         id,
         from: this.portName,

app-vite/lib/cache/module.animations.js

@@ -6,5 +6,5 @@ export async function createInstance({ appPaths }) {
     appPaths.appDir
   )
 
-  return generalAnimations.concat(inAnimations).concat(outAnimations)
+  return [...generalAnimations, ...inAnimations, ...outAnimations]
 }

app-vite/lib/cache/module.nodePackager.js

@@ -19,7 +19,7 @@ function getMajorVersion(name) {
     const child = crossSpawnSync(name, ['--version'])
     if (child.status === 0) {
       const version = String(child.output[1]).trim()
-      return parseInt(version.split('.')[0], 10)
+      return Number.parseInt(version.split('.')[0], 10)
     }
   } catch {
     /* do nothing; we return null below */
@@ -206,7 +206,7 @@ class Bun extends PackageManager {
 function getProjectPackageManager(packageManagersList, dir) {
   // Recursively checks for presence of the lock file by traversing
   // the dir tree up to the root
-  while (dir.length !== 0 && dir[dir.length - 1] !== sep) {
+  while (dir.length !== 0 && dir.at(-1) !== sep) {
     for (const pm of packageManagersList) {
       if (pm.lockFiles.some(lockFile => fs.existsSync(join(dir, lockFile)))) {
         return pm

app-vite/lib/cmd/build.js

@@ -162,6 +162,8 @@ await ctx.appExt.runAppExtensionHook('beforeBuild', async hook => {
 })
 
 log()
+
+// oxlint-disable-next-line unicorn/prefer-top-level-await
 appBuilder
   .build()
   .catch(err => {

app-vite/lib/cmd/describe.js

@@ -468,28 +468,31 @@ function printQuasarConfOptions({ quasarConfOptions }) {
 
 function describe(api) {
   switch (api.type) {
-    case 'component':
+    case 'component': {
       if (apiParts.quasar === true) printQuasarConfOptions(api)
       if (apiParts.props === true) printProperties(api)
       if (apiParts.slots === true) printSlots(api)
       if (apiParts.events === true) printEvents(api)
       if (apiParts.methods === true) printMethods(api)
       if (apiParts.computedProps === true) printComputedProps(api)
       break
+    }
 
-    case 'directive':
+    case 'directive': {
       if (apiParts.quasar === true) printQuasarConfOptions(api)
       if (apiParts.value === true) printValue(api)
       if (apiParts.arg === true) printArg(api)
       if (apiParts.modifiers === true) printModifiers(api)
       break
+    }
 
-    case 'plugin':
+    case 'plugin': {
       if (apiParts.injection === true) printInjection(api)
       if (apiParts.quasar === true) printQuasarConfOptions(api)
       if (apiParts.props === true) printProperties(api)
       if (apiParts.methods === true) printMethods(api)
       break
+    }
   }
 
   if (api.meta && api.meta.docsUrl) {
@@ -576,7 +579,9 @@ async function listElements() {
 }
 
 if (item === 'list') {
+  // oxlint-disable-next-line unicorn/prefer-top-level-await
   listElements()
 } else {
+  // oxlint-disable-next-line unicorn/prefer-top-level-await
   run()
 }

app-vite/lib/cmd/dev.js

@@ -178,16 +178,16 @@ const onQuasarConfChange = qConf => {
   devServer.run(qConf)
 }
 
-devServer.run(quasarConf).then(async () => {
-  if (typeof quasarConf.build.afterDev === 'function') {
-    await quasarConf.build.afterDev({ quasarConf })
-  }
+await devServer.run(quasarConf)
 
-  // run possible afterDev hooks
-  await ctx.appExt.runAppExtensionHook('afterDev', async hook => {
-    log(`Extension(${hook.api.extId}): Running afterDev hook...`)
-    await hook.fn(hook.api, { quasarConf })
-  })
+if (typeof quasarConf.build.afterDev === 'function') {
+  await quasarConf.build.afterDev({ quasarConf })
+}
 
-  quasarConfFile.watch(onQuasarConfChange)
+// run possible afterDev hooks
+await ctx.appExt.runAppExtensionHook('afterDev', async hook => {
+  log(`Extension(${hook.api.extId}): Running afterDev hook...`)
+  await hook.fn(hook.api, { quasarConf })
 })
+
+quasarConfFile.watch(onQuasarConfChange)

app-vite/lib/cmd/inspect.js

@@ -74,7 +74,7 @@ if (isModeInstalled(ctx.appPaths, argv.mode) !== true) {
   fatal('Requested mode for inspection is NOT installed.')
 }
 
-const depth = parseInt(argv.depth, 10) || Infinity
+const depth = Number.parseInt(argv.depth, 10) || Infinity
 
 import { QuasarConfigFile } from '../quasar-config-file.js'
 const quasarConfFile = new QuasarConfigFile({

app-vite/lib/cmd/mode.js

@@ -140,6 +140,7 @@ function displayModes() {
 }
 
 if (argv._.length === 2) {
+  // oxlint-disable-next-line unicorn/prefer-top-level-await
   run()
 } else {
   displayModes()

app-vite/lib/cmd/new.js

@@ -218,23 +218,19 @@ async function getAsset(assetType) {
   }
 }
 
-async function generate() {
-  const { relativePath, ext, reference } = await getAsset(type)
-  const fullExt = `.${ext}`
+const { relativePath, ext, reference } = await getAsset(type)
+const fullExt = `.${ext}`
 
-  names.forEach(name => {
-    const file = join(
-      relativePath,
-      name + (name.endsWith(fullExt) ? '' : fullExt)
-    )
-    const targetFile = appPaths.resolve.app(file)
-
-    createFile({
-      targetFile,
-      ext,
-      reference
-    })
-  })
-}
+names.forEach(name => {
+  const file = join(
+    relativePath,
+    name + (name.endsWith(fullExt) ? '' : fullExt)
+  )
+  const targetFile = appPaths.resolve.app(file)
 
-generate()
+  createFile({
+    targetFile,
+    ext,
+    reference
+  })
+})