Skip to content

Commit 5f6944a

Browse files
committed
Fix conditional checks for java and rustc in the tests.
1 parent 474907d commit 5f6944a

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

test/jruby-tests/dependencies_test.sh

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ function setUp()
1111

1212
function test_when_java_is_not_installed_and_package_manager_is_apt()
1313
{
14-
command -v java >/dev/null && return
14+
! command -v java >/dev/null || return 0
1515

1616
local original_package_manager="$package_manager"
1717
package_manager="apt"
@@ -27,7 +27,7 @@ function test_when_java_is_not_installed_and_package_manager_is_apt()
2727

2828
function test_when_java_is_not_installed_and_package_manager_is_dnf()
2929
{
30-
command -v java >/dev/null && return
30+
! command -v java >/dev/null || return 0
3131

3232
local original_package_manager="$package_manager"
3333
package_manager="dnf"
@@ -43,7 +43,7 @@ function test_when_java_is_not_installed_and_package_manager_is_dnf()
4343

4444
function test_when_java_is_not_installed_and_package_manager_is_yum()
4545
{
46-
command -v java >/dev/null && return
46+
! command -v java >/dev/null || return 0
4747

4848
local original_package_manager="$package_manager"
4949
package_manager="yum"
@@ -59,7 +59,7 @@ function test_when_java_is_not_installed_and_package_manager_is_yum()
5959

6060
function test_when_java_is_not_installed_and_package_manager_is_pacman()
6161
{
62-
command -v java >/dev/null && return
62+
! command -v java >/dev/null || return 0
6363

6464
local original_package_manager="$package_manager"
6565
package_manager="pacman"
@@ -75,7 +75,7 @@ function test_when_java_is_not_installed_and_package_manager_is_pacman()
7575

7676
function test_when_java_is_not_installed_and_package_manager_is_zypper()
7777
{
78-
command -v java >/dev/null && return
78+
! command -v java >/dev/null || return 0
7979

8080
local original_package_manager="$package_manager"
8181
package_manager="zypper"
@@ -91,7 +91,7 @@ function test_when_java_is_not_installed_and_package_manager_is_zypper()
9191

9292
function test_when_java_is_not_installed_and_package_manager_is_xbps()
9393
{
94-
command -v java >/dev/null && return
94+
! command -v java >/dev/null || return 0
9595

9696
local original_package_manager="$package_manager"
9797
package_manager="xbps"
@@ -107,7 +107,7 @@ function test_when_java_is_not_installed_and_package_manager_is_xbps()
107107

108108
function test_when_java_is_not_installed_and_package_manager_is_brew()
109109
{
110-
command -v java >/dev/null && return
110+
! command -v java >/dev/null || return 0
111111

112112
local original_package_manager="$package_manager"
113113
package_manager="brew"
@@ -123,7 +123,7 @@ function test_when_java_is_not_installed_and_package_manager_is_brew()
123123

124124
function test_when_java_is_not_installed_and_package_manager_is_port()
125125
{
126-
command -v java >/dev/null && return
126+
! command -v java >/dev/null || return 0
127127

128128
local original_package_manager="$package_manager"
129129
package_manager="port"
@@ -139,7 +139,7 @@ function test_when_java_is_not_installed_and_package_manager_is_port()
139139

140140
function test_when_java_is_not_installed_and_package_manager_is_pkg()
141141
{
142-
command -v java >/dev/null && return
142+
! command -v java >/dev/null || return 0
143143

144144
local original_package_manager="$package_manager"
145145
package_manager="pkg"
@@ -155,7 +155,7 @@ function test_when_java_is_not_installed_and_package_manager_is_pkg()
155155

156156
function test_when_java_is_installed()
157157
{
158-
command -v java >/dev/null || return
158+
command -v java >/dev/null || return 0
159159

160160
source "$ruby_install_dir/$ruby/dependencies.sh"
161161

test/ruby-tests/dependencies_test.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -549,7 +549,7 @@ function test_ruby_dependencies_when_with_jemalloc_is_given()
549549

550550
function test_ruby_dependencies_when_enable_yjit_is_given_and_rustc_is_not_installed_and_the_package_manager_is_apt()
551551
{
552-
command -v rustc && return
552+
! command -v rustc >/dev/null || return 0
553553

554554
local original_package_manager="$package_manager"
555555
local original_configure_opts=("${configure_opts[@]}")
@@ -568,7 +568,7 @@ function test_ruby_dependencies_when_enable_yjit_is_given_and_rustc_is_not_insta
568568

569569
function test_ruby_dependencies_when_enable_yjit_is_given_and_rustc_is_not_installed_and_the_package_manager_is_not_apt()
570570
{
571-
command -v rustc >/dev/null && return
571+
! command -v rustc >/dev/null || return 0
572572

573573
local original_package_manager="$package_manager"
574574
local original_configure_opts=("${configure_opts[@]}")
@@ -587,7 +587,7 @@ function test_ruby_dependencies_when_enable_yjit_is_given_and_rustc_is_not_insta
587587

588588
function test_ruby_dependencies_when_enable_yjit_is_given_but_rustc_is_installed()
589589
{
590-
command -v rustc >/dev/null || return
590+
command -v rustc >/dev/null || return 0
591591

592592
local original_configure_opts=("${configure_opts[@]}")
593593

0 commit comments

Comments
 (0)