Skip to content

TeamResult weight is unused, it should be multiplied together with PlayerResult weight #3

@Kermalis

Description

@Kermalis

In Adjudicator, there's a method called calculatePlayerRatingAdjustment() which has these lines:

double weight = omega > 0 ? playerResult.weight() : 1 / playerResult.weight();

Nowhere else in the project are weights used, meaning the TeamResult weight is unused. It should be multiplied together with the playerResult weight here I believe like

double weight = playerResult.weight() * teamResult.weight();
weight = omega > 0 ? weight : 1 / weight;

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions