Fix provider cache atomic write temp path collisions#2291
Draft
juliusmarminge wants to merge 4 commits intomainfrom
Draft
Fix provider cache atomic write temp path collisions#2291juliusmarminge wants to merge 4 commits intomainfrom
juliusmarminge wants to merge 4 commits intomainfrom
Conversation
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
juliusmarminge
commented
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Why
Provider cache writes used temp filenames derived from
process.pidandDate.now(). Two writes to the same cache file in the same process and same millisecond could pick the same temp path, causing onerename()to move the file and the other to fail withENOENT. The helper now creates a scoped temp directory beside the target file and writes a UUID-named temp file before the final atomic rename, removing that collision class while keeping the implementation inside Effect APIs.Checklist
Note
Fix provider cache atomic write temp path collisions using random UUIDs
makeAtomicWriteTempPathin atomicWrite.ts that generates unique temp paths usingprocess.pid+crypto.randomUUID()instead of time-based suffixes, preventing collisions on concurrent writes.writeFileStringAtomicallyas a shared Effect-based utility that handles directory creation, temp file write, rename, and cleanup.writeProviderStatusCache,persistServerRuntimeState,writeSettingsAtomically, andwriteConfigAtomicallyto all delegate to this shared utility, removing duplicated atomic write logic.writeProviderStatusCachethat verifies two parallel writes to the same file both succeed without data corruption.Macroscope summarized fc43d5f. (Automatic summaries will resume when PR exits draft mode or review begins).