Skip to content

tests(ticdc): mq protocol framework relies on git root for compose paths #12606

@wlwilliamx

Description

@wlwilliamx

What did you do?

Investigated a CI failure pattern caused by repo-local test assets being resolved through git rev-parse --show-toplevel.

tests/mq_protocol_tests/framework still uses github.com/integralist/go-findroot/find.Repo() to locate docker-compose files and log paths. In worktree or symlinked checkouts, git metadata can resolve to a parent or canonical directory that does not directly contain the checked-out source tree, which makes these paths invalid.

What did you expect to see?

The mq protocol test framework should resolve repo-local compose and log paths from the checked-out source tree regardless of whether the repository is a normal clone, a git worktree, or a symlinked checkout.

What did you see instead?

The framework relies on git metadata for path discovery, so it can build incorrect compose and log paths and fail before the docker-compose environment is initialized.

Versions of the cluster

Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

Not applicable. This is a repository test framework path-resolution bug.

Upstream TiKV version (execute tikv-server --version):

Not applicable. This is a repository test framework path-resolution bug.

TiCDC version (execute cdc version):

master (source checkout)

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions