Fix: Return an error if the query function is not supported. (#539)

Author: PierrePaul

src/Controller/CustomController.php

@@ -4,6 +4,7 @@
 
 use Slim\App;
 use XHGui\AbstractController;
+use XHGui\Exception\NotImplementedException;
 use XHGui\RequestProxy as Request;
 use XHGui\Searcher\SearcherInterface;
 
@@ -55,7 +56,12 @@ public function query($query, $retrieve)
         }
 
         $perPage = $this->config('page.limit');
+        try {
+            $results = $this->searcher->query($conditions, $perPage, $fields);
+        } catch (NotImplementedException $e) {
+            return ['error' => ['generic' => 'Not available for your save handler.']];
+        }
 
-        return $this->searcher->query($conditions, $perPage, $fields);
+        return $results;
     }
 }

templates/custom/create.twig

@@ -39,19 +39,12 @@
     </div><!--/span-->
 
   </div><!--/row-->
-    <div class="row-fluid">
-
-    <div class="span12">
+ <div class="row-fluid">
+    <div class="span12" id="run-button-container">
         <div class="btn btn-large" style="display: block; margin-left: auto; margin-right: auto; width: 150px;" id="runbutton">Run</div>
 		<div style="display: block; margin-left: auto; margin-right: auto; width: 150px; display: none" id="loading"><img src="{{ static('img/loading.gif') }}"></div>
     </div><!--/span-->
 
-
-
-
-
-
-  
   </div><!--/row-->
   <table class="table table-hover" id="results">
     <thead>
@@ -105,7 +98,6 @@
                     $("#loading").hide();
                     if (data.hasOwnProperty('error'))
                     {
-                      console.log(data.error);
                       if (data.error.hasOwnProperty('query'))
                       {
                         $('#selection').animate(
@@ -127,6 +119,18 @@
                         }
                         );
                       }
+
+                      if (data.error.hasOwnProperty('generic'))
+                      {
+                          $('#run-button-container').animate(
+                              { backgroundColor: '#FFD9D9'},
+                              800,
+                              function() {
+                                  $(this).animate({ backgroundColor: '#FFF'});
+                              }
+                          );
+                          $('#run-button-container').text(data.error.generic);
+                      }
                     }else  {
                       $.each( data, function(i, n){
                          $("#results tbody").append('<tr><td>' + n.meta.url + '</td><td>' + n.meta.SERVER.REQUEST_TIME + '</td><td>' + n.profile['main()'].wt + '</td><td>' + n.profile['main()'].cpu + '</td><td>' + n.profile['main()'].mu + '</td><td>' + n.profile['main()'].pmu + '</td></tr>');