Fix all remaining lint: line length, too-many-arguments, protected-access, import-outside-toplevel

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: neha-sanse

percy/robot_library.py

@@ -35,9 +35,9 @@
 _screenshot_module = None
 
 def _get_screenshot_module():
-    global _screenshot_module
+    global _screenshot_module  # pylint: disable=global-statement
     if _screenshot_module is None:
-        from percy import screenshot as _mod
+        from percy import screenshot as _mod  # pylint: disable=import-outside-toplevel
         _screenshot_module = _mod
     return _screenshot_module
 
@@ -125,12 +125,14 @@ def _get_page(self):
         # --------------------------------------------------------------
 
         @keyword("Percy Snapshot")
-        def percy_snapshot_keyword(self, name, widths=None, min_height=None,
-                                   percy_css=None, scope=None, scope_options=None,
-                                   enable_javascript=None, enable_layout=None,
-                                   disable_shadow_dom=None, labels=None,
-                                   test_case=None, sync=None, regions=None,
-                                   responsive_snapshot_capture=None):
+        def percy_snapshot_keyword(  # pylint: disable=too-many-arguments,too-many-locals
+            self, name, widths=None, min_height=None,
+            percy_css=None, scope=None, scope_options=None,
+            enable_javascript=None, enable_layout=None,
+            disable_shadow_dom=None, labels=None,
+            test_case=None, sync=None, regions=None,
+            responsive_snapshot_capture=None,
+        ):
             """Capture a Percy visual snapshot of the current page.
 
             ``name`` is the snapshot name shown in the Percy dashboard.
@@ -184,14 +186,16 @@ def percy_snapshot_keyword(self, name, widths=None, min_height=None,
         # --------------------------------------------------------------
 
         @keyword("Create Percy Region")
-        def create_percy_region_keyword(self, algorithm="ignore",
-                                         bounding_box=None, element_xpath=None,
-                                         element_css=None, padding=None,
-                                         diff_sensitivity=None,
-                                         image_ignore_threshold=None,
-                                         carousels_enabled=None,
-                                         banners_enabled=None, ads_enabled=None,
-                                         diff_ignore_threshold=None):
+        def create_percy_region_keyword(  # pylint: disable=too-many-arguments
+            self, algorithm="ignore",
+            bounding_box=None, element_xpath=None,
+            element_css=None, padding=None,
+            diff_sensitivity=None,
+            image_ignore_threshold=None,
+            carousels_enabled=None,
+            banners_enabled=None, ads_enabled=None,
+            diff_ignore_threshold=None,
+        ):
             """Create a region definition for Percy ignore/consider regions.
 
             ``algorithm`` is one of ``ignore``, ``standard``, or ``intelliignore``.
@@ -215,7 +219,9 @@ def create_percy_region_keyword(self, algorithm="ignore",
                 padding=int(padding) if padding else None,
                 algorithm=algorithm,
                 diffSensitivity=int(diff_sensitivity) if diff_sensitivity else None,
-                imageIgnoreThreshold=float(image_ignore_threshold) if image_ignore_threshold else None,
+                imageIgnoreThreshold=(
+                    float(image_ignore_threshold) if image_ignore_threshold else None
+                ),
                 carouselsEnabled=_parse_bool(carousels_enabled),
                 bannersEnabled=_parse_bool(banners_enabled),
                 adsEnabled=_parse_bool(ads_enabled),
@@ -233,11 +239,11 @@ def percy_is_running_keyword(self):
             Returns ``True`` if Percy is available, ``False`` otherwise.
             """
             mod = _get_screenshot_module()
-            return bool(mod._is_percy_enabled())
+            return bool(mod._is_percy_enabled())  # pylint: disable=protected-access
 
 else:
-    class PercyLibrary:  # pylint: disable=function-redefined
-        """Stub — robotframework is not installed."""
+    class PercyLibrary:  # pylint: disable=function-redefined,too-few-public-methods
+        """Stub -- robotframework is not installed."""
         def __init__(self):
             raise ImportError(
                 "robotframework is not installed. "

tests/test_robot_library.py

@@ -6,13 +6,15 @@
 import sys
 from unittest.mock import MagicMock, patch
 
-# Mock playwright before any percy imports
+# Mock playwright before any percy imports  pylint: disable=protected-access
 _mock_playwright = MagicMock()
-_mock_playwright._repo_version.version = "1.50.0"
+_mock_playwright._repo_version.version = "1.50.0"  # pylint: disable=protected-access
 _mock_playwright.sync_api.Error = Exception
 _mock_playwright.sync_api.TimeoutError = TimeoutError
 sys.modules.setdefault("playwright", _mock_playwright)
-sys.modules.setdefault("playwright._repo_version", _mock_playwright._repo_version)
+sys.modules.setdefault(  # pylint: disable=protected-access
+    "playwright._repo_version", _mock_playwright._repo_version
+)
 sys.modules.setdefault("playwright.sync_api", _mock_playwright.sync_api)
 
 from percy.robot_library import (  # noqa: E402 pylint: disable=wrong-import-position
@@ -87,7 +89,10 @@ def test_percy_is_running(self, mock_get_mod):
     @patch("percy.robot_library._get_screenshot_module")
     def test_create_region(self, mock_get_mod):
         mock_mod = MagicMock()
-        mock_mod.create_region.return_value = {"algorithm": "ignore", "elementSelector": {"elementCSS": ".ad"}}
+        mock_mod.create_region.return_value = {
+            "algorithm": "ignore",
+            "elementSelector": {"elementCSS": ".ad"},
+        }
         mock_get_mod.return_value = mock_mod
 
         lib = PercyLibrary()