ability to use allowDiskUse on mongo

[stewones]

New Feature / Enhancement Checklist

• I am not disclosing a vulnerability.
• I am not just asking a question.
• I have searched through existing issues.

Current Limitation

currently it's not possible to set allowDiskUse as option to queries

Feature / Enhancement Description

according to this comment, starting with mongo v5.12.8 it would be possible to pass allowDiskUse through setOptions

Automattic/mongoose#10177 (comment)

await Test.find().sort({ name: 1 }).setOptions({ allowDiskUse: true }).exec();

Example Use Case

query.find({ allowDiskUse: true }).then(function(results) {
  // Request succeeded
}, function(error) {
  // Request failed
});

Alternatives / Workarounds

N/A

3rd Party References

N/A

[parse-github-assistant]

Thanks for opening this issue!

• 🎉 We are excited about your ideas for improvement!

[mtrezza]

That sounds like a good addition, allowDiskUse has been added in MongoDB 4.4.

[stewones]

Yo @mtrezza

Do you think that would be too crazy to implement? I'm willing to set up parse for dev and have a shot

[mtrezza]

I think it would be straight forward to implement. It's just another option that can be passed in Parse.Query which is then passed through to the MongoDB driver. You could take a look at Parse.Query.readPreference for how an option is passed to the driver. You would basically replicate that and rename it Parse.Query.allowDiskUse.

[aclec]

Hello @stewones can you implement it for aggregates too?
Otherwise I will do it later.

[mtrezza]

It seems that no PR has ever been submitted for this issue, so feel free to submit one.

[stewones]

hey guys, I've left the company I was working for which would benefit from this feature, so completely lost the interest for now. but would love to see this feature added.

[stewones]

alright I need this for a pet project now, looking into 👀

[stewones]

got it working for the find method, now need to add tests and support aggregate as well.
PR coming in a few hours 🫡

[stewones]

@mtrezza

would be super awesome to get some feedback asap on this PR parse-community/Parse-SDK-JS#1619

we gonna need it for the new feature

in order to use allowDiskUse mongo requires at least one sort otherwise an error is thrown by Mongo but ParseError can't recognize it causing [object Object] as a log message, which in turn makes it impossible to figure what's going on.

once that PR ^ is accepted Parse will be able to print those errors like this

[mtrezza]

How is this feature dependent on or related to parse-community/Parse-SDK-JS#1619? That PR seems to be only about making log messages more readable.

[stewones]

Sorry I expressed myself badly, too much excitement 🙈

It's not dependent, actually, it's just frustrating cause Parse should print errors like in that ^ screenshot but it doesn't. So user wants to use allowDiskUse, an error is thrown and they don't know that this option requires a sort. that PR fixes it and other edge cases.. like I got a Parse server running monitored by GCP Error Reporting and I currently can't figure out some errors due to this issue. Error message gets blank.

[mtrezza]

Got it, let me mark this as off-topic, as these comments really belong to the other issue it seems. I reviewed the other PR and posted some thoughts. Let's continue the discussion there.