Skip to content

Commit 373735c

Browse files
committed
fix: use ID equality instead of object identity for self-player checks
1 parent cb3f8cd commit 373735c

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/client/graphics/layers/RadialMenuElements.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -442,7 +442,7 @@ function buildPresetItem(slot: PresetSlot, recipient: PlayerView): MenuElement {
442442
name: "trade",
443443
disabled: (p: MenuElementParams) =>
444444
p.selected === null ||
445-
p.selected === p.myPlayer ||
445+
p.selected?.id() === p.myPlayer?.id() ||
446446
(!p.playerActions?.interaction?.canEmbargo &&
447447
!p.playerActions?.interaction?.canDonateGold),
448448
color: (p: MenuElementParams) =>
@@ -459,7 +459,7 @@ function buildPresetItem(slot: PresetSlot, recipient: PlayerView): MenuElement {
459459
action: (p: MenuElementParams) => {
460460
if (
461461
p.selected === null ||
462-
p.selected === p.myPlayer ||
462+
p.selected?.id() === p.myPlayer?.id() ||
463463
(!p.playerActions?.interaction?.canEmbargo &&
464464
!p.playerActions?.interaction?.canDonateGold)
465465
)
@@ -502,7 +502,7 @@ export const infoMenuElement: MenuElement = {
502502
if (params === undefined || !params.selected) return [];
503503

504504
const recipient = params.selected;
505-
const isSelf = params.selected === params.myPlayer;
505+
const isSelf = params.selected?.id() === params.myPlayer?.id();
506506

507507
// On own territory: skip chat presets, just show Info and Configure
508508
const presets = isSelf ? [] : QuickChatPresetService.getInstance().load();

0 commit comments

Comments
 (0)