Commit faf526c
refactor: apply review feedback (round 1)
Objective: Code review identified 6 issues across CI workflow,
shell scripts, SKILL.md references, and .gitignore.
Approach: Accept 6 items, reject 4 items with technical reasoning.
- CI: remove nonexistent --fix flag from error message, fix
unreachable exit-code logic with set +e
- Shell: add executable bit (100755) to detect-env.sh, hybrid-health.sh
- SKILL.md: add eval-metrics.md to reference table, fix quick-eval.py
usage from --input/--reference flags to positional args
- .gitignore: remove duplicate __pycache__ entry (already covered
by **/__pycache__/ on line 53)
Evidence: git ls-tree confirms 100755 for .sh files.
grep confirms no remaining --fix references in CI.
SKILL.md quick-eval.py example matches argparse positional interface.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent 14cf497 commit faf526c
File tree
5 files changed
+6
-7
lines changed- .github/workflows
- skills/odl-pdf
- scripts
5 files changed
+6
-7
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| 28 | + | |
28 | 29 | | |
29 | | - | |
| 30 | + | |
| 31 | + | |
30 | 32 | | |
31 | 33 | | |
32 | | - | |
| 34 | + | |
33 | 35 | | |
34 | 36 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
78 | | - | |
79 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
363 | 363 | | |
364 | 364 | | |
365 | 365 | | |
366 | | - | |
367 | | - | |
368 | | - | |
| 366 | + | |
369 | 367 | | |
370 | 368 | | |
371 | 369 | | |
| |||
686 | 684 | | |
687 | 685 | | |
688 | 686 | | |
| 687 | + | |
689 | 688 | | |
690 | 689 | | |
691 | 690 | | |
| |||
File mode changed.
File mode changed.
0 commit comments