From 07e8ee71bad0f111875f20a1eeb1e6b05c72676c Mon Sep 17 00:00:00 2001 From: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com> Date: Tue, 7 Apr 2026 12:46:09 +0530 Subject: [PATCH 1/6] fix(test): impact analysis selector fix --- .../src/main/resources/ui/playwright/utils/lineage.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openmetadata-ui/src/main/resources/ui/playwright/utils/lineage.ts b/openmetadata-ui/src/main/resources/ui/playwright/utils/lineage.ts index 70d5e3cb0b53..46dddb1fb3a1 100644 --- a/openmetadata-ui/src/main/resources/ui/playwright/utils/lineage.ts +++ b/openmetadata-ui/src/main/resources/ui/playwright/utils/lineage.ts @@ -642,7 +642,7 @@ export const getEntityColumns = ( }; export const openImpactAnalysisTab = async (page: Page) => { - const impactAnalysisTab = page.getByRole('tab', { + const impactAnalysisTab = page.getByRole('button', { name: 'Impact Analysis', }); From 37156e9c7a061544dcaa57e53309f1f1900b4fe6 Mon Sep 17 00:00:00 2001 From: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com> Date: Tue, 7 Apr 2026 14:30:01 +0530 Subject: [PATCH 2/6] fix lineage spec --- .../resources/ui/playwright/utils/common.ts | 30 +++++++++---------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/openmetadata-ui/src/main/resources/ui/playwright/utils/common.ts b/openmetadata-ui/src/main/resources/ui/playwright/utils/common.ts index 6fc5f557075d..3e723e433db3 100644 --- a/openmetadata-ui/src/main/resources/ui/playwright/utils/common.ts +++ b/openmetadata-ui/src/main/resources/ui/playwright/utils/common.ts @@ -151,21 +151,21 @@ const DASHBOARD_DATA_MODEL = 'DashboardDataModel'; export const getEntityTypeSearchIndexMapping = (entityType: string) => { const entityMapping = { - Table: 'table', - Topic: 'topic', - Dashboard: 'dashboard', - Pipeline: 'pipeline', - MlModel: 'mlmodel', - Container: 'container', - SearchIndex: 'searchIndex', - ApiEndpoint: 'apiEndpoint', - Metric: 'metric', - ['Store Procedure']: 'storedProcedure', - Directory: 'directory', - File: 'file', - Spreadsheet: 'spreadsheet', - Worksheet: 'worksheet', - [DASHBOARD_DATA_MODEL]: 'dashboardDataModel', + Table: 'table_search_index', + Topic: 'topic_search_index', + Dashboard: 'dashboard_search_index', + Pipeline: 'pipeline_search_index', + MlModel: 'mlmodel_search_index', + Container: 'container_search_index', + SearchIndex: 'search_entity_search_index', + ApiEndpoint: 'api_endpoint_search_index', + Metric: 'metric_search_index', + ['Store Procedure']: 'stored_procedure_search_index', + Directory: 'directory_search_index', + File: 'file_search_index', + Spreadsheet: 'spreadsheet_search_index', + Worksheet: 'worksheet_search_index', + [DASHBOARD_DATA_MODEL]: 'dashboard_data_model_search_index', }; return entityMapping[entityType as keyof typeof entityMapping]; From 2722cf7694a7622c6109aac8f70936e7a3fc5690 Mon Sep 17 00:00:00 2001 From: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com> Date: Tue, 7 Apr 2026 14:36:21 +0530 Subject: [PATCH 3/6] fix tests --- .../src/main/resources/ui/playwright/utils/lineage.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/openmetadata-ui/src/main/resources/ui/playwright/utils/lineage.ts b/openmetadata-ui/src/main/resources/ui/playwright/utils/lineage.ts index 46dddb1fb3a1..e122d68a53ba 100644 --- a/openmetadata-ui/src/main/resources/ui/playwright/utils/lineage.ts +++ b/openmetadata-ui/src/main/resources/ui/playwright/utils/lineage.ts @@ -719,9 +719,9 @@ export const verifyCSVHeaders = async (headers: string[]) => { }; export const getLineageCSVData = async (page: Page) => { - await expect(page.getByTestId('export-button')).toBeEnabled(); + await expect(page.getByRole('button', { name: 'Export' })).toBeEnabled(); - await page.getByTestId('export-button').click(); + await page.getByRole('button', { name: 'Export' }).click(); await page .locator('[data-testid="export-entity-modal"] #submit-button') @@ -804,9 +804,9 @@ export const verifyExportLineagePNG = async ( page: Page, isPNGSelected?: boolean ) => { - await expect(page.getByTestId('export-button')).toBeEnabled(); + await expect(page.getByRole('button', { name: 'Export' })).toBeEnabled(); - await page.getByTestId('export-button').click(); + await page.getByRole('button', { name: 'Export' }).click(); await page .locator('[data-testid="export-entity-modal"] #submit-button') From 39229720486e96e081b3985635c4bfcb45baf534 Mon Sep 17 00:00:00 2001 From: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com> Date: Tue, 7 Apr 2026 14:50:32 +0530 Subject: [PATCH 4/6] fix filter button issue --- .../playwright/e2e/Features/ImpactAnalysis.spec.ts | 14 +++++++------- .../e2e/Pages/Lineage/LineageFilters.spec.ts | 4 ++-- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/ImpactAnalysis.spec.ts b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/ImpactAnalysis.spec.ts index 3370a36412aa..72d3ef02b7f5 100644 --- a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/ImpactAnalysis.spec.ts +++ b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/ImpactAnalysis.spec.ts @@ -429,7 +429,7 @@ test.describe('Impact Analysis', () => { test('verify owner filter for Asset level impact analysis', async ({ page, }) => { - await page.getByTestId('filters-button').click(); + await page.getByRole('button', { name: 'Filters' }).click(); await page.getByTestId('search-dropdown-Owners').click(); await expect( @@ -456,7 +456,7 @@ test.describe('Impact Analysis', () => { }); test('verify domain for Asset level impact analysis', async ({ page }) => { - await page.getByTestId('filters-button').click(); + await page.getByRole('button', { name: 'Filters' }).click(); await page.getByTestId('search-dropdown-Domains').click(); await expect( @@ -485,7 +485,7 @@ test.describe('Impact Analysis', () => { }); test('verify tier for Asset level impact analysis', async ({ page }) => { - await page.getByTestId('filters-button').click(); + await page.getByRole('button', { name: 'Filters' }).click(); await page.getByTestId('search-dropdown-Tier').click(); await expect( @@ -874,7 +874,7 @@ test.describe('Impact Analysis', () => { test('Verify service type filter for Asset level impact analysis', async ({ page, }) => { - await page.getByTestId('filters-button').click(); + await page.getByRole('button', { name: 'Filters' }).click(); await page.getByTestId('search-dropdown-Service Type').click(); const serviceTypeOption = page.getByTitle('mlflow', { exact: true }); @@ -917,7 +917,7 @@ test.describe('Impact Analysis', () => { const initialRowCount = await page.locator('[data-row-key]').count(); - await page.getByTestId('filters-button').click(); + await page.getByRole('button', { name: 'Filters' }).click(); await page.getByTestId('search-dropdown-Tag').click(); await waitForAllLoadersToDisappear(page); @@ -978,7 +978,7 @@ test.describe('Impact Analysis', () => { test('Verify switching between table and column level clears filters', async ({ page, }) => { - await page.getByTestId('filters-button').click(); + await page.getByRole('button', { name: 'Filters' }).click(); await page.getByTestId('search-dropdown-Tier').click(); await page @@ -1043,7 +1043,7 @@ test.describe('Impact Analysis', () => { await columnLineageResponse; await waitForAllLoadersToDisappear(page); - await page.getByTestId('filters-button').click(); + await page.getByRole('button', { name: 'Filters' }).click(); await page.getByTestId('search-dropdown-Glossary Terms').click(); const glossaryOptions = page .getByTestId('drop-down-menu') diff --git a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Lineage/LineageFilters.spec.ts b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Lineage/LineageFilters.spec.ts index 48d64dd93062..20f407a275dc 100644 --- a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Lineage/LineageFilters.spec.ts +++ b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Lineage/LineageFilters.spec.ts @@ -274,7 +274,7 @@ test.describe('Lineage Filters', () => { await page.reload(); await waitForAllLoadersToDisappear(page); - await page.getByTestId('filters-button').click(); + await page.getByRole('button', { name: 'Filters' }).click(); await page.getByTestId(`search-dropdown-${filterTestId}`).click(); await page.getByTitle(filterValue).click(); @@ -316,7 +316,7 @@ test.describe('Lineage Filters', () => { await impactAnalysisTab.click(); await waitForAllLoadersToDisappear(page); - await page.getByTestId('filters-button').click(); + await page.getByRole('button', { name: 'Filters' }).click(); await page.getByTestId(`search-dropdown-${filterTestId}`).click(); await page From 681f719b24dd91964e350e01db003dbb9c2812c6 Mon Sep 17 00:00:00 2001 From: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com> Date: Tue, 7 Apr 2026 17:15:59 +0530 Subject: [PATCH 5/6] fix missing piece --- .../src/main/resources/ui/playwright/utils/lineage.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openmetadata-ui/src/main/resources/ui/playwright/utils/lineage.ts b/openmetadata-ui/src/main/resources/ui/playwright/utils/lineage.ts index e122d68a53ba..3c7e4b69fad8 100644 --- a/openmetadata-ui/src/main/resources/ui/playwright/utils/lineage.ts +++ b/openmetadata-ui/src/main/resources/ui/playwright/utils/lineage.ts @@ -124,7 +124,7 @@ export const editLineageClick = async (page: Page) => { export const editLineage = async (page: Page) => { await editLineageClick(page); - await expect(page.getByTestId('table-draggable-icon')).toBeVisible(); + await expect(page.getByTestId('table_search_index-draggable-icon')).toBeVisible(); }; export const performZoomOut = async (page: Page, xTimes = 10) => { From 1a987e3706801bff6bec294c773aad98bff153b3 Mon Sep 17 00:00:00 2001 From: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com> Date: Tue, 7 Apr 2026 17:21:12 +0530 Subject: [PATCH 6/6] fix failing spec --- .../ui/playwright/e2e/Pages/Lineage/DataAssetLineage.spec.ts | 1 + .../ui/playwright/e2e/Pages/Lineage/LineageFilters.spec.ts | 2 ++ .../ui/playwright/e2e/Pages/Lineage/PlatformLineage.spec.ts | 1 + 3 files changed, 4 insertions(+) diff --git a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Lineage/DataAssetLineage.spec.ts b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Lineage/DataAssetLineage.spec.ts index 33bcdfb12d5b..458fbcfe0b1e 100644 --- a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Lineage/DataAssetLineage.spec.ts +++ b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Lineage/DataAssetLineage.spec.ts @@ -460,6 +460,7 @@ test.describe('Lineage Settings modal', () => { }); test.beforeEach(async ({ page }) => { + await redirectToHomePage(page); await table.visitEntityPage(page); await visitLineageTab(page); }); diff --git a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Lineage/LineageFilters.spec.ts b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Lineage/LineageFilters.spec.ts index 20f407a275dc..80a0ac04c4e0 100644 --- a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Lineage/LineageFilters.spec.ts +++ b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Lineage/LineageFilters.spec.ts @@ -32,6 +32,7 @@ import { getApiContext, getDefaultAdminAPIContext, getEntityTypeSearchIndexMapping, + redirectToHomePage, } from '../../../utils/common'; import { waitForAllLoadersToDisappear } from '../../../utils/entity'; import { @@ -124,6 +125,7 @@ test.describe('Lineage Filters', () => { }); test.beforeEach(async ({ page }) => { + await redirectToHomePage(page); await lineageEntity.visitEntityPage(page); await visitLineageTab(page); await waitForAllLoadersToDisappear(page); diff --git a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Lineage/PlatformLineage.spec.ts b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Lineage/PlatformLineage.spec.ts index aa987921d9aa..d96e54125663 100644 --- a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Lineage/PlatformLineage.spec.ts +++ b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Lineage/PlatformLineage.spec.ts @@ -55,6 +55,7 @@ test.beforeAll(async ({ browser }) => { }); test.beforeEach(async ({ page }) => { + await redirectToHomePage(page); await table.visitEntityPage(page); await visitLineageTab(page); await performZoomOut(page);