fix(ui): add fallback to interaction required error in MsalAuthenticator (#27189)

* fix(ui): add fallback to interaction required error

* fix(ui): update MsalAuthenticator test to validate popup-fallback path

Agent-Logs-Url: https://github.com/open-metadata/OpenMetadata/sessions/b430d4e3-eead-4b95-9b4e-0b6775ca20e6

Co-authored-by: chirag-madlani <12962843+chirag-madlani@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

Author: chirag-madlani

openmetadata-ui/src/main/resources/ui/src/components/Auth/AppAuthenticators/MsalAuthenticator.test.tsx

@@ -36,6 +36,18 @@ jest.mock('../../../utils/AuthProvider.util', () => ({
   })),
 }));
 
+jest.mock('../../../utils/ToastUtils', () => ({
+  showErrorToast: jest.fn(),
+}));
+
+jest.mock('../../../utils/CommonUtils', () => ({
+  Transi18next: jest.fn(() => null),
+}));
+
+jest.mock('../../../utils/BrowserUtils', () => ({
+  getPopupSettingLink: jest.fn(() => 'https://example.com/popup-settings'),
+}));
+
 const mockInstance = {
   loginPopup: jest.fn(),
   loginRedirect: jest.fn(),
@@ -162,11 +174,37 @@ describe('MsalAuthenticator', () => {
     expect(result).toBe('mock-id-token');
   });
 
-  it('should throw InteractionRequiredAuthError when renewIdToken encounters expired session', async () => {
+  it('should fall back to loginPopup when renewIdToken encounters InteractionRequiredAuthError', async () => {
+    const interactionError = new InteractionRequiredAuthError(
+      'interaction_required'
+    );
+    mockInstance.acquireTokenSilent.mockRejectedValueOnce(interactionError);
+    mockInstance.loginPopup.mockResolvedValueOnce({
+      account: { username: 'test@example.com' },
+      idToken: 'popup-token',
+    });
+
+    render(
+      <MsalAuthenticator
+        {...mockProps}
+        ref={(ref) => (authenticatorRef = ref)}
+      />
+    );
+
+    const result = await authenticatorRef?.renewIdToken();
+
+    expect(mockInstance.acquireTokenSilent).toHaveBeenCalled();
+    expect(mockInstance.loginPopup).toHaveBeenCalled();
+    expect(result).toBe('mock-id-token');
+  });
+
+  it('should throw when renewIdToken popup fallback also fails', async () => {
     const interactionError = new InteractionRequiredAuthError(
       'interaction_required'
     );
+    const popupError = new Error('popup_window_error');
     mockInstance.acquireTokenSilent.mockRejectedValueOnce(interactionError);
+    mockInstance.loginPopup.mockRejectedValueOnce(popupError);
 
     render(
       <MsalAuthenticator
@@ -176,9 +214,10 @@ describe('MsalAuthenticator', () => {
     );
 
     await expect(authenticatorRef?.renewIdToken()).rejects.toThrow(
-      InteractionRequiredAuthError
+      'popup_window_error'
     );
     expect(mockInstance.acquireTokenSilent).toHaveBeenCalled();
+    expect(mockInstance.loginPopup).toHaveBeenCalled();
   });
 
   it('should show loader when interaction is in progress', () => {

openmetadata-ui/src/main/resources/ui/src/components/Auth/AppAuthenticators/MsalAuthenticator.tsx

@@ -133,7 +133,7 @@ const MsalAuthenticator = forwardRef<AuthenticatorRef, Props>(
     };
 
     const renewIdToken = async () => {
-      const user = await fetchIdToken();
+      const user = await fetchIdToken(true);
 
       return user.id_token;
     };