Skip to content

Commit 9b25b26

Browse files
fix(test): impact analysis selector fix (#27118)
* fix(test): impact analysis selector fix * fix lineage spec * fix tests * fix filter button issue * fix missing piece * fix failing spec
1 parent 85981bf commit 9b25b26

File tree

6 files changed

+34
-30
lines changed

6 files changed

+34
-30
lines changed

openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/ImpactAnalysis.spec.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -429,7 +429,7 @@ test.describe('Impact Analysis', () => {
429429
test('verify owner filter for Asset level impact analysis', async ({
430430
page,
431431
}) => {
432-
await page.getByTestId('filters-button').click();
432+
await page.getByRole('button', { name: 'Filters' }).click();
433433
await page.getByTestId('search-dropdown-Owners').click();
434434

435435
await expect(
@@ -456,7 +456,7 @@ test.describe('Impact Analysis', () => {
456456
});
457457

458458
test('verify domain for Asset level impact analysis', async ({ page }) => {
459-
await page.getByTestId('filters-button').click();
459+
await page.getByRole('button', { name: 'Filters' }).click();
460460
await page.getByTestId('search-dropdown-Domains').click();
461461

462462
await expect(
@@ -485,7 +485,7 @@ test.describe('Impact Analysis', () => {
485485
});
486486

487487
test('verify tier for Asset level impact analysis', async ({ page }) => {
488-
await page.getByTestId('filters-button').click();
488+
await page.getByRole('button', { name: 'Filters' }).click();
489489
await page.getByTestId('search-dropdown-Tier').click();
490490

491491
await expect(
@@ -874,7 +874,7 @@ test.describe('Impact Analysis', () => {
874874
test('Verify service type filter for Asset level impact analysis', async ({
875875
page,
876876
}) => {
877-
await page.getByTestId('filters-button').click();
877+
await page.getByRole('button', { name: 'Filters' }).click();
878878
await page.getByTestId('search-dropdown-Service Type').click();
879879

880880
const serviceTypeOption = page.getByTitle('mlflow', { exact: true });
@@ -917,7 +917,7 @@ test.describe('Impact Analysis', () => {
917917

918918
const initialRowCount = await page.locator('[data-row-key]').count();
919919

920-
await page.getByTestId('filters-button').click();
920+
await page.getByRole('button', { name: 'Filters' }).click();
921921
await page.getByTestId('search-dropdown-Tag').click();
922922

923923
await waitForAllLoadersToDisappear(page);
@@ -978,7 +978,7 @@ test.describe('Impact Analysis', () => {
978978
test('Verify switching between table and column level clears filters', async ({
979979
page,
980980
}) => {
981-
await page.getByTestId('filters-button').click();
981+
await page.getByRole('button', { name: 'Filters' }).click();
982982
await page.getByTestId('search-dropdown-Tier').click();
983983

984984
await page
@@ -1043,7 +1043,7 @@ test.describe('Impact Analysis', () => {
10431043
await columnLineageResponse;
10441044
await waitForAllLoadersToDisappear(page);
10451045

1046-
await page.getByTestId('filters-button').click();
1046+
await page.getByRole('button', { name: 'Filters' }).click();
10471047
await page.getByTestId('search-dropdown-Glossary Terms').click();
10481048
const glossaryOptions = page
10491049
.getByTestId('drop-down-menu')

openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Lineage/DataAssetLineage.spec.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -460,6 +460,7 @@ test.describe('Lineage Settings modal', () => {
460460
});
461461

462462
test.beforeEach(async ({ page }) => {
463+
await redirectToHomePage(page);
463464
await table.visitEntityPage(page);
464465
await visitLineageTab(page);
465466
});

openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Lineage/LineageFilters.spec.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ import {
3232
getApiContext,
3333
getDefaultAdminAPIContext,
3434
getEntityTypeSearchIndexMapping,
35+
redirectToHomePage,
3536
} from '../../../utils/common';
3637
import { waitForAllLoadersToDisappear } from '../../../utils/entity';
3738
import {
@@ -124,6 +125,7 @@ test.describe('Lineage Filters', () => {
124125
});
125126

126127
test.beforeEach(async ({ page }) => {
128+
await redirectToHomePage(page);
127129
await lineageEntity.visitEntityPage(page);
128130
await visitLineageTab(page);
129131
await waitForAllLoadersToDisappear(page);
@@ -274,7 +276,7 @@ test.describe('Lineage Filters', () => {
274276
await page.reload();
275277
await waitForAllLoadersToDisappear(page);
276278

277-
await page.getByTestId('filters-button').click();
279+
await page.getByRole('button', { name: 'Filters' }).click();
278280
await page.getByTestId(`search-dropdown-${filterTestId}`).click();
279281

280282
await page.getByTitle(filterValue).click();
@@ -316,7 +318,7 @@ test.describe('Lineage Filters', () => {
316318
await impactAnalysisTab.click();
317319
await waitForAllLoadersToDisappear(page);
318320

319-
await page.getByTestId('filters-button').click();
321+
await page.getByRole('button', { name: 'Filters' }).click();
320322
await page.getByTestId(`search-dropdown-${filterTestId}`).click();
321323

322324
await page

openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Lineage/PlatformLineage.spec.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ test.beforeAll(async ({ browser }) => {
5555
});
5656

5757
test.beforeEach(async ({ page }) => {
58+
await redirectToHomePage(page);
5859
await table.visitEntityPage(page);
5960
await visitLineageTab(page);
6061
await performZoomOut(page);

openmetadata-ui/src/main/resources/ui/playwright/utils/common.ts

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -151,21 +151,21 @@ const DASHBOARD_DATA_MODEL = 'DashboardDataModel';
151151

152152
export const getEntityTypeSearchIndexMapping = (entityType: string) => {
153153
const entityMapping = {
154-
Table: 'table',
155-
Topic: 'topic',
156-
Dashboard: 'dashboard',
157-
Pipeline: 'pipeline',
158-
MlModel: 'mlmodel',
159-
Container: 'container',
160-
SearchIndex: 'searchIndex',
161-
ApiEndpoint: 'apiEndpoint',
162-
Metric: 'metric',
163-
['Store Procedure']: 'storedProcedure',
164-
Directory: 'directory',
165-
File: 'file',
166-
Spreadsheet: 'spreadsheet',
167-
Worksheet: 'worksheet',
168-
[DASHBOARD_DATA_MODEL]: 'dashboardDataModel',
154+
Table: 'table_search_index',
155+
Topic: 'topic_search_index',
156+
Dashboard: 'dashboard_search_index',
157+
Pipeline: 'pipeline_search_index',
158+
MlModel: 'mlmodel_search_index',
159+
Container: 'container_search_index',
160+
SearchIndex: 'search_entity_search_index',
161+
ApiEndpoint: 'api_endpoint_search_index',
162+
Metric: 'metric_search_index',
163+
['Store Procedure']: 'stored_procedure_search_index',
164+
Directory: 'directory_search_index',
165+
File: 'file_search_index',
166+
Spreadsheet: 'spreadsheet_search_index',
167+
Worksheet: 'worksheet_search_index',
168+
[DASHBOARD_DATA_MODEL]: 'dashboard_data_model_search_index',
169169
};
170170

171171
return entityMapping[entityType as keyof typeof entityMapping];

openmetadata-ui/src/main/resources/ui/playwright/utils/lineage.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ export const editLineageClick = async (page: Page) => {
124124
export const editLineage = async (page: Page) => {
125125
await editLineageClick(page);
126126

127-
await expect(page.getByTestId('table-draggable-icon')).toBeVisible();
127+
await expect(page.getByTestId('table_search_index-draggable-icon')).toBeVisible();
128128
};
129129

130130
export const performZoomOut = async (page: Page, xTimes = 10) => {
@@ -642,7 +642,7 @@ export const getEntityColumns = (
642642
};
643643

644644
export const openImpactAnalysisTab = async (page: Page) => {
645-
const impactAnalysisTab = page.getByRole('tab', {
645+
const impactAnalysisTab = page.getByRole('button', {
646646
name: 'Impact Analysis',
647647
});
648648

@@ -719,9 +719,9 @@ export const verifyCSVHeaders = async (headers: string[]) => {
719719
};
720720

721721
export const getLineageCSVData = async (page: Page) => {
722-
await expect(page.getByTestId('export-button')).toBeEnabled();
722+
await expect(page.getByRole('button', { name: 'Export' })).toBeEnabled();
723723

724-
await page.getByTestId('export-button').click();
724+
await page.getByRole('button', { name: 'Export' }).click();
725725

726726
await page
727727
.locator('[data-testid="export-entity-modal"] #submit-button')
@@ -804,9 +804,9 @@ export const verifyExportLineagePNG = async (
804804
page: Page,
805805
isPNGSelected?: boolean
806806
) => {
807-
await expect(page.getByTestId('export-button')).toBeEnabled();
807+
await expect(page.getByRole('button', { name: 'Export' })).toBeEnabled();
808808

809-
await page.getByTestId('export-button').click();
809+
await page.getByRole('button', { name: 'Export' }).click();
810810

811811
await page
812812
.locator('[data-testid="export-entity-modal"] #submit-button')

0 commit comments

Comments
 (0)