Unable to set up a confirm before app close function.

[Allasso]

(MacOS)

Using this:

win.on("close", () => {
  if (confirm("close window?")) {
    win.close(true);
  }
});

If I confirm close, app closes fine. If I don't confirm, I am no longer able to close the app, I need to force quit. I tried to re-attach the listener:

win.on("close", () => {
	handleWinClose();
});

function handleWinClose() {
  if (confirm("close window?")) {
		win.close(true);
  } else {
		win.on("close", () => {
			handleWinClose();
		});
  }
};

but it doesn't help. Apparently the "close" event is only fired once, ever. Any workaround for this?

[Allasso]

Update on this: Actually, it appears that it is only that the window will no longer close if using the File menu > "Quit " selection. It will close if closing the window via x button on upper left corner, or by using Cmd+Q. Unfortunately I cannot expect my users to not attempt to quit the application through the File menu.

[elusien]

It works fine for me. Try changing the code to reflect mine by inserting return true;

function handleWinClose() {
  if (confirm("close window?")) {
		win.close(true);
  } else {
		win.on("close", () => {
			handleWinClose();
		});
  }
};

to

function handleWinClose() {
  if (confirm("close window?")) {
		win.close(true);
        return true;
  } else {
		return true;
  }
};

[GnorTech]

Thanks for the report. A few notes:

The close event listener is not one-shot — it stays active after firing. You don't need to re-attach it in the else branch. This simpler form should work:

win.on("close", function() {
  if (confirm("Close window?")) {
    win.close(true);
  }
});

The issue you're seeing is specific to File > Quit on macOS. The X button and Cmd+Q use a different close path internally, which is why they continue to work after you cancel. File > Quit goes through a shutdown manager that doesn't properly reset its state when the close is canceled by your handler.

Could you confirm:

1. Does the simpler code above (without re-attaching) work correctly with X button and Cmd+Q after canceling?
2. Is it only File > Quit that stops working after the first cancel?

This would help narrow down the fix.