src: fix crash in GetErrorSource() for invalid using syntax

Author: semimikoh

src/node_errors.cc

@@ -150,8 +150,7 @@ static std::string GetErrorSource(Isolate* isolate,
                          : 0;
   int start = message->GetStartColumn(context).FromMaybe(0);
   int end = message->GetEndColumn(context).FromMaybe(0);
-  if (start >= script_start) {
-    CHECK_GE(end, start);
+  if (start >= script_start && end >= script_start) {
     start -= script_start;
     end -= script_start;
   }
@@ -163,6 +162,7 @@ static std::string GetErrorSource(Isolate* isolate,
 
   if (start > end ||
       start < 0 ||
+      end < 0 ||
       static_cast<size_t>(end) > sourceline.size()) {
     return buf;
   }

test/parallel/test-cli-eval-invalid-using.js

@@ -0,0 +1,23 @@
+'use strict';
+
+require('../common');
+const assert = require('assert');
+const { spawnSyncAndAssert } = require('../common/child_process');
+
+[
+  '{using x=null, []=null;}',
+  '{using x=null, {}=null;}',
+  'async function f() { { await using x=null, []=null; } }',
+  'async function f() { { await using x=null, {}=null; } }',
+].forEach((script) => {
+  spawnSyncAndAssert(process.execPath, ['--eval', script], {
+    status: 1,
+    signal: null,
+    stderr(output) {
+      assert.match(output, /SyntaxError/);
+      assert.doesNotMatch(output, /Assertion failed/);
+      assert.doesNotMatch(output, /Native stack trace/);
+    },
+    stdout: '',
+  });
+});