Skip to content

Commit 12d376b

Browse files
committed
FIX Generate Insert Query feature
1 parent c1ab8f6 commit 12d376b

File tree

1 file changed

+15
-3
lines changed

1 file changed

+15
-3
lines changed

packages/plugins/formatter/extension.ts

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import vscode from 'vscode';
44
import Config from '@sqltools/util/config-manager';
55
import { formatInsertQuery, format as queryFormat } from '@sqltools/util/query';
66
import { insertText, getOrCreateEditor } from '@sqltools/vscode/utils';
7-
import { NSDatabase, IExtension } from '@sqltools/types';
7+
import { NSDatabase, IExtension, ContextValue } from '@sqltools/types';
88
import { SidebarItem } from '../connection-manager/explorer';
99
import { EXT_NAMESPACE } from '@sqltools/util/constants';
1010

@@ -73,10 +73,22 @@ async function generateDefinitionQueryHandler(item: SidebarItem) {
7373
}
7474

7575
async function generateInsertQueryHandler(item: SidebarItem) {
76-
const columns: NSDatabase.IColumn[] = await commands.executeCommand(`${EXT_NAMESPACE}.getChildrenForTreeItem`, {
76+
let columns: NSDatabase.IColumn[];
77+
columns = await commands.executeCommand(`${EXT_NAMESPACE}.getChildrenForTreeItem`, {
7778
conn: item.conn,
78-
item: item.metadata,
79+
item: {
80+
type: ContextValue.RESOURCE_GROUP,
81+
childType: ContextValue.COLUMN
82+
},
83+
parent: item.metadata,
7984
});
85+
// this is for backward compatibility with third-party drivers
86+
if (columns.filter((item) => item.type === ContextValue.COLUMN).length === 0) {
87+
columns = await commands.executeCommand(`${EXT_NAMESPACE}.getChildrenForTreeItem`, {
88+
conn: item.conn,
89+
item: item.metadata,
90+
});
91+
}
8092
const insertQuery: string = await commands.executeCommand(`${EXT_NAMESPACE}.getInsertQuery`, {
8193
conn: item.conn,
8294
item: item.metadata,

0 commit comments

Comments
 (0)