BufferAttribute setFromVector, setFromColor convenience methods

Kodub · Kodub · commit bbf484d4aeb3 · 2026-04-15T18:42:51.000+09:00
diff --git a/examples/jsm/csm/CSMHelper.js b/examples/jsm/csm/CSMHelper.js
@@ -191,15 +191,15 @@ class CSMHelper extends Group {
 
 		const nearVerts = mainFrustum.vertices.near;
 		const farVerts = mainFrustum.vertices.far;
-		frustumLinePositions.setXYZ( 0, farVerts[ 0 ].x, farVerts[ 0 ].y, farVerts[ 0 ].z );
-		frustumLinePositions.setXYZ( 1, farVerts[ 3 ].x, farVerts[ 3 ].y, farVerts[ 3 ].z );
-		frustumLinePositions.setXYZ( 2, farVerts[ 2 ].x, farVerts[ 2 ].y, farVerts[ 2 ].z );
-		frustumLinePositions.setXYZ( 3, farVerts[ 1 ].x, farVerts[ 1 ].y, farVerts[ 1 ].z );
-
-		frustumLinePositions.setXYZ( 4, nearVerts[ 0 ].x, nearVerts[ 0 ].y, nearVerts[ 0 ].z );
-		frustumLinePositions.setXYZ( 5, nearVerts[ 3 ].x, nearVerts[ 3 ].y, nearVerts[ 3 ].z );
-		frustumLinePositions.setXYZ( 6, nearVerts[ 2 ].x, nearVerts[ 2 ].y, nearVerts[ 2 ].z );
-		frustumLinePositions.setXYZ( 7, nearVerts[ 1 ].x, nearVerts[ 1 ].y, nearVerts[ 1 ].z );
+		frustumLinePositions.setFromVector3( 0, farVerts[ 0 ] );
+		frustumLinePositions.setFromVector3( 1, farVerts[ 3 ] );
+		frustumLinePositions.setFromVector3( 2, farVerts[ 2 ] );
+		frustumLinePositions.setFromVector3( 3, farVerts[ 1 ] );
+
+		frustumLinePositions.setFromVector3( 4, nearVerts[ 0 ] );
+		frustumLinePositions.setFromVector3( 5, nearVerts[ 3 ] );
+		frustumLinePositions.setFromVector3( 6, nearVerts[ 2 ] );
+		frustumLinePositions.setFromVector3( 7, nearVerts[ 1 ] );
 		frustumLinePositions.needsUpdate = true;
 
 	}
diff --git a/examples/jsm/exporters/GLTFExporter.js b/examples/jsm/exporters/GLTFExporter.js
@@ -884,7 +884,7 @@ class GLTFWriter {
 
 			}
 
-			attribute.setXYZ( i, v.x, v.y, v.z );
+			attribute.setFromVector3( i, v );
 
 		}
 
diff --git a/examples/jsm/helpers/TextureHelper.js b/examples/jsm/helpers/TextureHelper.js
@@ -203,11 +203,7 @@ function createCubeGeometry( width, height, depth ) {
 
 		_direction.fromBufferAttribute( position, j ).normalize();
 
-		const u = _direction.x;
-		const v = _direction.y;
-		const w = _direction.z;
-
-		uvw.setXYZ( j, u, v, w );
+		uvw.setFromVector3( j, _direction );
 
 	}
 
diff --git a/examples/jsm/helpers/TextureHelperGPU.js b/examples/jsm/helpers/TextureHelperGPU.js
@@ -152,11 +152,7 @@ function createCubeGeometry( width, height, depth ) {
 
 		_direction.fromBufferAttribute( position, j ).normalize();
 
-		const u = _direction.x;
-		const v = _direction.y;
-		const w = _direction.z;
-
-		uvw.setXYZ( j, u, v, w );
+		uvw.setFromVector3( j, _direction );
 
 	}
 
diff --git a/examples/jsm/helpers/VertexNormalsHelper.js b/examples/jsm/helpers/VertexNormalsHelper.js
@@ -123,11 +123,11 @@ class VertexNormalsHelper extends LineSegments {
 
 				_v2.applyMatrix3( _normalMatrix ).normalize().multiplyScalar( this.size ).add( _v1 );
 
-				position.setXYZ( idx, _v1.x, _v1.y, _v1.z );
+				position.setFromVector3( idx, _v1 );
 
 				idx = idx + 1;
 
-				position.setXYZ( idx, _v2.x, _v2.y, _v2.z );
+				position.setFromVector3( idx, _v2 );
 
 				idx = idx + 1;
 
diff --git a/examples/jsm/helpers/VertexTangentsHelper.js b/examples/jsm/helpers/VertexTangentsHelper.js
@@ -103,11 +103,11 @@ class VertexTangentsHelper extends LineSegments {
 
 			_v2.transformDirection( matrixWorld ).multiplyScalar( this.size ).add( _v1 );
 
-			position.setXYZ( idx, _v1.x, _v1.y, _v1.z );
+			position.setFromVector3( idx, _v1 );
 
 			idx = idx + 1;
 
-			position.setXYZ( idx, _v2.x, _v2.y, _v2.z );
+			position.setFromVector3( idx, _v2 );
 
 			idx = idx + 1;
 
diff --git a/examples/jsm/loaders/DRACOLoader.js b/examples/jsm/loaders/DRACOLoader.js
@@ -322,7 +322,7 @@ class DRACOLoader extends Loader {
 
 			_color.fromBufferAttribute( attribute, i );
 			ColorManagement.colorSpaceToWorking( _color, SRGBColorSpace );
-			attribute.setXYZ( i, _color.r, _color.g, _color.b );
+			attribute.setFromColor( i, _color );
 
 		}
 
diff --git a/examples/jsm/loaders/VRMLLoader.js b/examples/jsm/loaders/VRMLLoader.js
@@ -3220,7 +3220,7 @@ class VRMLLoader extends Loader {
 
 				ColorManagement.colorSpaceToWorking( color, SRGBColorSpace );
 
-				attribute.setXYZ( i, color.r, color.g, color.b );
+				attribute.setFromColor( i, color );
 
 			}
 
@@ -3327,7 +3327,7 @@ class VRMLLoader extends Loader {
 
 				ColorManagement.colorSpaceToWorking( color, SRGBColorSpace );
 
-				colorAttribute.setXYZ( index, color.r, color.g, color.b );
+				colorAttribute.setFromColor( index, color );
 
 			}
 
diff --git a/examples/jsm/utils/BufferGeometryUtils.js b/examples/jsm/utils/BufferGeometryUtils.js
@@ -1406,7 +1406,7 @@ function toCreasedNormals( geometry, creaseAngle = Math.PI / 3 /* 60 degrees */
 			}
 
 			tempNorm2.normalize();
-			normAttr.setXYZ( i3 + n, tempNorm2.x, tempNorm2.y, tempNorm2.z );
+			normAttr.setFromVector3( i3 + n, tempNorm2 );
 
 		}
 
diff --git a/examples/misc_controls_pointerlock.html b/examples/misc_controls_pointerlock.html
@@ -200,7 +200,7 @@
 					vertex.y += Math.random() * 2;
 					vertex.z += Math.random() * 20 - 10;
 
-					position.setXYZ( i, vertex.x, vertex.y, vertex.z );
+					position.setFromVector3( i, vertex );
 
 				}
 
diff --git a/examples/webgl_decals.html b/examples/webgl_decals.html
@@ -198,8 +198,8 @@
 						mouseHelper.lookAt( n );
 
 						const positions = line.geometry.attributes.position;
-						positions.setXYZ( 0, p.x, p.y, p.z );
-						positions.setXYZ( 1, n.x, n.y, n.z );
+						positions.setFromVector3( 0, p );
+						positions.setFromVector3( 1, n );
 						positions.needsUpdate = true;
 
 						intersection.intersects = true;
diff --git a/examples/webgl_geometry_colors.html b/examples/webgl_geometry_colors.html
@@ -120,13 +120,13 @@
 				for ( let i = 0; i < count; i ++ ) {
 
 					color.setHSL( ( positions1.getY( i ) / radius + 1 ) / 2, 1.0, 0.5, THREE.SRGBColorSpace );
-					colors1.setXYZ( i, color.r, color.g, color.b );
+					colors1.setFromColor( i, color );
 
 					color.setHSL( 0, ( positions2.getY( i ) / radius + 1 ) / 2, 0.5, THREE.SRGBColorSpace );
-					colors2.setXYZ( i, color.r, color.g, color.b );
+					colors2.setFromColor( i, color );
 
 					color.setRGB( 1, 0.8 - ( positions3.getY( i ) / radius + 1 ) / 2, 0, THREE.SRGBColorSpace );
-					colors3.setXYZ( i, color.r, color.g, color.b );
+					colors3.setFromColor( i, color );
 
 				}
 
diff --git a/examples/webgl_geometry_colors_lookuptable.html b/examples/webgl_geometry_colors_lookuptable.html
@@ -185,7 +185,7 @@
 
 					color.copy( lut.getColor( colorValue ) ).convertSRGBToLinear();
 
-					colors.setXYZ( i, color.r, color.g, color.b );
+					colors.setFromColor( i, color );
 
 				}
 
diff --git a/examples/webgl_geometry_spline_editor.html b/examples/webgl_geometry_spline_editor.html
@@ -293,7 +293,7 @@
 
 						const t = i / ( ARC_SEGMENTS - 1 );
 						spline.getPoint( t, point );
-						position.setXYZ( i, point.x, point.y, point.z );
+						position.setFromVector3( i, point );
 
 					}
 
diff --git a/examples/webgl_multiple_views.html b/examples/webgl_multiple_views.html
@@ -169,13 +169,13 @@
 				for ( let i = 0; i < count; i ++ ) {
 
 					color.setHSL( ( positions1.getY( i ) / radius + 1 ) / 2, 1.0, 0.5, THREE.SRGBColorSpace );
-					colors1.setXYZ( i, color.r, color.g, color.b );
+					colors1.setFromColor( i, color );
 
 					color.setHSL( 0, ( positions2.getY( i ) / radius + 1 ) / 2, 0.5, THREE.SRGBColorSpace );
-					colors2.setXYZ( i, color.r, color.g, color.b );
+					colors2.setFromColor( i, color );
 
 					color.setRGB( 1, 0.8 - ( positions3.getY( i ) / radius + 1 ) / 2, 0, THREE.SRGBColorSpace );
-					colors3.setXYZ( i, color.r, color.g, color.b );
+					colors3.setFromColor( i, color );
 
 				}
 
diff --git a/examples/webgl_raycaster_bvh.html b/examples/webgl_raycaster_bvh.html
@@ -234,13 +234,13 @@
 						_matrix.compose( point, _quaternion, _scale );
 						sphereInstance.setMatrixAt( i * 2 + 1, _matrix );
 
-						lineSegments.geometry.attributes.position.setXYZ( lineNum ++, _position.x, _position.y, _position.z );
-						lineSegments.geometry.attributes.position.setXYZ( lineNum ++, point.x, point.y, point.z );
+						lineSegments.geometry.attributes.position.setFromVector3( lineNum ++, _position );
+						lineSegments.geometry.attributes.position.setFromVector3( lineNum ++, point );
 
 					} else {
 
 						sphereInstance.setMatrixAt( i * 2 + 1, _matrix );
-						lineSegments.geometry.attributes.position.setXYZ( lineNum ++, _position.x, _position.y, _position.z );
+						lineSegments.geometry.attributes.position.setFromVector3( lineNum ++, _position );
 						lineSegments.geometry.attributes.position.setXYZ( lineNum ++, 0, 0, 0 );
 
 					}
diff --git a/src/core/BufferAttribute.js b/src/core/BufferAttribute.js
@@ -269,7 +269,7 @@ class BufferAttribute extends EventDispatcher {
 				_vector2.fromBufferAttribute( this, i );
 				_vector2.applyMatrix3( m );
 
-				this.setXY( i, _vector2.x, _vector2.y );
+				this.setFromVector2( i, _vector2 );
 
 			}
 
@@ -280,7 +280,7 @@ class BufferAttribute extends EventDispatcher {
 				_vector.fromBufferAttribute( this, i );
 				_vector.applyMatrix3( m );
 
-				this.setXYZ( i, _vector.x, _vector.y, _vector.z );
+				this.setFromVector3( i, _vector );
 
 			}
 
@@ -305,7 +305,7 @@ class BufferAttribute extends EventDispatcher {
 
 			_vector.applyMatrix4( m );
 
-			this.setXYZ( i, _vector.x, _vector.y, _vector.z );
+			this.setFromVector3( i, _vector );
 
 		}
 
@@ -328,7 +328,7 @@ class BufferAttribute extends EventDispatcher {
 
 			_vector.applyNormalMatrix( m );
 
-			this.setXYZ( i, _vector.x, _vector.y, _vector.z );
+			this.setFromVector3( i, _vector );
 
 		}
 
@@ -351,7 +351,7 @@ class BufferAttribute extends EventDispatcher {
 
 			_vector.transformDirection( m );
 
-			this.setXYZ( i, _vector.x, _vector.y, _vector.z );
+			this.setFromVector3( i, _vector );
 
 		}
 
@@ -629,6 +629,58 @@ class BufferAttribute extends EventDispatcher {
 
 	}
 
+	/**
+	 * Sets the x and y component of the vector at the given index based on the values of the given vector.
+	 *
+	 * @param {number} index - The index into the buffer attribute.
+	 * @param {Vector2} vector - The vector to set.
+	 * @return {BufferAttribute} A reference to this instance.
+	 */
+	setFromVector2( index, vector ) {
+
+		return this.setXY( index, vector.x, vector.y );
+
+	}
+
+	/**
+	 * Sets the x, y and z component of the vector at the given index based on the values of the given vector.
+	 *
+	 * @param {number} index - The index into the buffer attribute.
+	 * @param {Vector3} vector - The vector to set.
+	 * @return {BufferAttribute} A reference to this instance.
+	 */
+	setFromVector3( index, vector ) {
+
+		return this.setXYZ( index, vector.x, vector.y, vector.z );
+
+	}
+
+	/**
+	 * Sets the x, y, z and w component of the vector at the given index based on the values of the given vector.
+	 *
+	 * @param {number} index - The index into the buffer attribute.
+	 * @param {Vector4} vector - The vector to set.
+	 * @return {BufferAttribute} A reference to this instance.
+	 */
+	setFromVector4( index, vector ) {
+
+		return this.setXYZW( index, vector.x, vector.y, vector.z, vector.w );
+
+	}
+
+	/**
+	 * Sets the x, y and z component of the vector at the given index based on the r, g and b values of the given color.
+	 *
+	 * @param {number} index - The index into the buffer attribute.
+	 * @param {Color} color - The color to set.
+	 * @return {BufferAttribute} A reference to this instance.
+	 */
+	setFromColor( index, color ) {
+
+		return this.setXYZ( index, color.r, color.g, color.b );
+
+	}
+
 	/**
 	 * Sets the given callback function that is executed after the Renderer has transferred
 	 * the attribute array data to the GPU. Can be used to perform clean-up operations after
diff --git a/src/core/BufferGeometry.js b/src/core/BufferGeometry.js
@@ -1040,9 +1040,9 @@ class BufferGeometry extends EventDispatcher {
 					nB.add( cb );
 					nC.add( cb );
 
-					normalAttribute.setXYZ( vA, nA.x, nA.y, nA.z );
-					normalAttribute.setXYZ( vB, nB.x, nB.y, nB.z );
-					normalAttribute.setXYZ( vC, nC.x, nC.y, nC.z );
+					normalAttribute.setFromVector3( vA, nA );
+					normalAttribute.setFromVector3( vB, nB );
+					normalAttribute.setFromVector3( vC, nC );
 
 				}
 
@@ -1060,9 +1060,9 @@ class BufferGeometry extends EventDispatcher {
 					ab.subVectors( pA, pB );
 					cb.cross( ab );
 
-					normalAttribute.setXYZ( i + 0, cb.x, cb.y, cb.z );
-					normalAttribute.setXYZ( i + 1, cb.x, cb.y, cb.z );
-					normalAttribute.setXYZ( i + 2, cb.x, cb.y, cb.z );
+					normalAttribute.setFromVector3( i + 0, cb );
+					normalAttribute.setFromVector3( i + 1, cb );
+					normalAttribute.setFromVector3( i + 2, cb );
 
 				}
 
@@ -1090,7 +1090,7 @@ class BufferGeometry extends EventDispatcher {
 
 			_vector.normalize();
 
-			normals.setXYZ( i, _vector.x, _vector.y, _vector.z );
+			normals.setFromVector3( i, _vector );
 
 		}
 
diff --git a/src/core/InterleavedBufferAttribute.js b/src/core/InterleavedBufferAttribute.js
diff --git a/src/helpers/CameraHelper.js b/src/helpers/CameraHelper.js
diff --git a/src/helpers/HemisphereLightHelper.js b/src/helpers/HemisphereLightHelper.js
diff --git a/src/helpers/SkeletonHelper.js b/src/helpers/SkeletonHelper.js
diff --git a/src/objects/SkinnedMesh.js b/src/objects/SkinnedMesh.js
diff --git a/test/unit/src/core/BufferAttribute.tests.js b/test/unit/src/core/BufferAttribute.tests.js

Original file line number	Diff line number	Diff line change
`@@ -884,7 +884,7 @@ class GLTFWriter {`
`884`	`884`
`885`	`885`	`}`
`886`	`886`
`887`		`- attribute.setXYZ( i, v.x, v.y, v.z );`
	`887`	`+ attribute.setFromVector3( i, v );`
`888`	`888`
`889`	`889`	`}`
`890`	`890`
Original file line number	Diff line number	Diff line change
`@@ -203,11 +203,7 @@ function createCubeGeometry( width, height, depth ) {`
`203`	`203`
`204`	`204`	`_direction.fromBufferAttribute( position, j ).normalize();`
`205`	`205`
`206`		`- const u = _direction.x;`
`207`		`- const v = _direction.y;`
`208`		`- const w = _direction.z;`
`209`		`-`
`210`		`- uvw.setXYZ( j, u, v, w );`
	`206`	`+ uvw.setFromVector3( j, _direction );`
`211`	`207`
`212`	`208`	`}`
`213`	`209`
Original file line number	Diff line number	Diff line change
`@@ -152,11 +152,7 @@ function createCubeGeometry( width, height, depth ) {`
`152`	`152`
`153`	`153`	`_direction.fromBufferAttribute( position, j ).normalize();`
`154`	`154`
`155`		`- const u = _direction.x;`
`156`		`- const v = _direction.y;`
`157`		`- const w = _direction.z;`
`158`		`-`
`159`		`- uvw.setXYZ( j, u, v, w );`
	`155`	`+ uvw.setFromVector3( j, _direction );`
`160`	`156`
`161`	`157`	`}`
`162`	`158`
Original file line number	Diff line number	Diff line change
`@@ -322,7 +322,7 @@ class DRACOLoader extends Loader {`
`322`	`322`
`323`	`323`	`_color.fromBufferAttribute( attribute, i );`
`324`	`324`	`ColorManagement.colorSpaceToWorking( _color, SRGBColorSpace );`
`325`		`- attribute.setXYZ( i, _color.r, _color.g, _color.b );`
	`325`	`+ attribute.setFromColor( i, _color );`
`326`	`326`
`327`	`327`	`}`
`328`	`328`
Original file line number	Diff line number	Diff line change
`@@ -3220,7 +3220,7 @@ class VRMLLoader extends Loader {`
`3220`	`3220`
`3221`	`3221`	`ColorManagement.colorSpaceToWorking( color, SRGBColorSpace );`
`3222`	`3222`
`3223`		`- attribute.setXYZ( i, color.r, color.g, color.b );`
	`3223`	`+ attribute.setFromColor( i, color );`
`3224`	`3224`
`3225`	`3225`	`}`
`3226`	`3226`
`@@ -3327,7 +3327,7 @@ class VRMLLoader extends Loader {`
`3327`	`3327`
`3328`	`3328`	`ColorManagement.colorSpaceToWorking( color, SRGBColorSpace );`
`3329`	`3329`
`3330`		`- colorAttribute.setXYZ( index, color.r, color.g, color.b );`
	`3330`	`+ colorAttribute.setFromColor( index, color );`
`3331`	`3331`
`3332`	`3332`	`}`
`3333`	`3333`
Original file line number	Diff line number	Diff line change
`@@ -1406,7 +1406,7 @@ function toCreasedNormals( geometry, creaseAngle = Math.PI / 3 /* 60 degrees */`
`1406`	`1406`	`}`
`1407`	`1407`
`1408`	`1408`	`tempNorm2.normalize();`
`1409`		`- normAttr.setXYZ( i3 + n, tempNorm2.x, tempNorm2.y, tempNorm2.z );`
	`1409`	`+ normAttr.setFromVector3( i3 + n, tempNorm2 );`
`1410`	`1410`
`1411`	`1411`	`}`
`1412`	`1412`
Original file line number	Diff line number	Diff line change
`@@ -200,7 +200,7 @@`
`200`	`200`	`vertex.y += Math.random() * 2;`
`201`	`201`	`vertex.z += Math.random() * 20 - 10;`
`202`	`202`
`203`		`- position.setXYZ( i, vertex.x, vertex.y, vertex.z );`
	`203`	`+ position.setFromVector3( i, vertex );`
`204`	`204`
`205`	`205`	`}`
`206`	`206`