Skip to content

Commit abf3ad7

Browse files
committed
feat: enhance accessibility by adding VisuallyHidden component for reminder title in TaskRowShare
1 parent 2edb969 commit abf3ad7

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

packages/web/src/components/retroui/Select.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ const SelectContent = ({
4242
<SelectPrimitive.Portal>
4343
<SelectPrimitive.Content
4444
className={cn(
45-
"relative z-50 min-w-[8rem] overflow-hidden border border-border bg-background text-popover-foreground shadow-md data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 data-[side=bottom]:slide-in-from-top-2 data-[side=left]:slide-in-from-right-2 data-[side=right]:slide-in-from-left-2 data-[side=top]:slide-in-from-bottom-2",
45+
"relative z-50 min-w-[8rem] max-h-[var(--radix-select-content-available-height)] overflow-hidden border border-border bg-background text-popover-foreground shadow-md data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 data-[side=bottom]:slide-in-from-top-2 data-[side=left]:slide-in-from-right-2 data-[side=right]:slide-in-from-left-2 data-[side=top]:slide-in-from-bottom-2",
4646
position === "popper" &&
4747
"data-[side=bottom]:translate-y-1 data-[side=left]:-translate-x-1 data-[side=right]:translate-x-1 data-[side=top]:-translate-y-1",
4848
className,
@@ -55,6 +55,7 @@ const SelectContent = ({
5555
</SelectPrimitive.ScrollUpButton>
5656
<SelectPrimitive.Viewport
5757
className={cn(
58+
"overflow-y-auto",
5859
position === "popper" &&
5960
"h-[var(--radix-select-trigger-height)] w-full min-w-[var(--radix-select-trigger-width)]",
6061
)}

packages/web/src/components/tasks/task-row-share.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ function copyToClipboard(text: string): Promise<void> {
2424
}
2525
}
2626
import { useSession } from "next-auth/react";
27+
import { VisuallyHidden } from "@radix-ui/react-visually-hidden";
2728
import {
2829
FaEnvelope,
2930
FaFacebookF,
@@ -450,6 +451,9 @@ export function TaskRowShare({
450451
</button>
451452
</Drawer.Trigger>
452453
<Drawer.Content className="max-h-[90vh] overflow-y-auto border-t-4 border-foreground bg-background">
454+
<VisuallyHidden>
455+
<Drawer.Title>{`Send reminder — ${taskTitle}`}</Drawer.Title>
456+
</VisuallyHidden>
453457
<ReminderComposer {...composerProps} />
454458
</Drawer.Content>
455459
</Drawer>

0 commit comments

Comments
 (0)