Commit d3b2f01
authored
FIX: Update time handling in Arrow integration to include fractional seconds (#499)
### Work Item / Issue Reference
<!--
IMPORTANT: Please follow the PR template guidelines below.
For mssql-python maintainers: Insert your ADO Work Item ID below
For external contributors: Insert Github Issue number below
Only one reference is required - either GitHub issue OR ADO Work Item.
-->
<!-- External contributors: GitHub Issue -->
> GitHub Issue: #498
-------------------------------------------------------------------
### Summary
<!-- Insert your summary of changes below. Minimum 10 characters
required. -->
Map SQL time types to the arrow nanosecond type and include the fraction
part of SQL_SS_TIME2_STRUCT in the value calculation.
For consistency, also remove the unreachable SQL_TIME and SQL_TYPE_TIME
branches.
<!--
### PR Title Guide
> For feature requests
FEAT: (short-description)
> For non-feature requests like test case updates, config updates ,
dependency updates etc
CHORE: (short-description)
> For Fix requests
FIX: (short-description)
> For doc update requests
DOC: (short-description)
> For Formatting, indentation, or styling update
STYLE: (short-description)
> For Refactor, without any feature changes
REFACTOR: (short-description)
> For release related changes, without any feature changes
RELEASE: #<RELEASE_VERSION> (short-description)
### Contribution Guidelines
External contributors:
- Create a GitHub issue first:
https://github.com/microsoft/mssql-python/issues/new
- Link the GitHub issue in the "GitHub Issue" section above
- Follow the PR title format and provide a meaningful summary
mssql-python maintainers:
- Create an ADO Work Item following internal processes
- Link the ADO Work Item in the "ADO Work Item" section above
- Follow the PR title format and provide a meaningful summary
-->1 parent 9bc78ae commit d3b2f01
File tree
2 files changed
+16
-24
lines changed- mssql_python/pybind
- tests
2 files changed
+16
-24
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
247 | 247 | | |
248 | 248 | | |
249 | 249 | | |
250 | | - | |
| 250 | + | |
251 | 251 | | |
252 | 252 | | |
253 | 253 | | |
| |||
4691 | 4691 | | |
4692 | 4692 | | |
4693 | 4693 | | |
4694 | | - | |
4695 | | - | |
4696 | 4694 | | |
4697 | | - | |
4698 | | - | |
4699 | | - | |
| 4695 | + | |
| 4696 | + | |
| 4697 | + | |
4700 | 4698 | | |
4701 | 4699 | | |
4702 | 4700 | | |
| |||
4965 | 4963 | | |
4966 | 4964 | | |
4967 | 4965 | | |
4968 | | - | |
4969 | | - | |
4970 | 4966 | | |
4971 | 4967 | | |
4972 | 4968 | | |
| |||
5226 | 5222 | | |
5227 | 5223 | | |
5228 | 5224 | | |
5229 | | - | |
5230 | | - | |
5231 | 5225 | | |
5232 | 5226 | | |
5233 | | - | |
5234 | | - | |
5235 | | - | |
5236 | | - | |
| 5227 | + | |
| 5228 | + | |
| 5229 | + | |
| 5230 | + | |
| 5231 | + | |
5237 | 5232 | | |
5238 | 5233 | | |
5239 | 5234 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
92 | | - | |
| 92 | + | |
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
97 | | - | |
| 97 | + | |
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
101 | 106 | | |
102 | 107 | | |
103 | 108 | | |
| |||
187 | 192 | | |
188 | 193 | | |
189 | 194 | | |
190 | | - | |
191 | | - | |
192 | | - | |
193 | | - | |
194 | | - | |
195 | | - | |
196 | | - | |
197 | | - | |
198 | 195 | | |
199 | 196 | | |
200 | 197 | | |
| |||
0 commit comments