minor changes

Author: bewithgaurav

main.py

@@ -1,10 +1,16 @@
 from mssql_python import connect
-from mssql_python import setup_logging
+from mssql_python import setup_logging, get_logger
 import os
 import decimal
 
 setup_logging('stdout')
 
+logger = get_logger()
+if logger:
+    logger.info("This should print")
+else:
+    print("Logger is None - logging not enabled!")
+
 conn_str = os.getenv("DB_CONNECTION_STRING")
 conn = connect(conn_str)
 

mssql_python/connection.py

@@ -18,7 +18,7 @@
 from mssql_python.helpers import add_driver_to_connection_str, sanitize_connection_string
 from mssql_python import ddbc_bindings
 from mssql_python.pooling import PoolingManager
-from mssql_python.exceptions import DatabaseError, InterfaceError
+from mssql_python.exceptions import InterfaceError
 
 logger = get_logger()
 
@@ -281,5 +281,7 @@ def __del__(self):
             try:
                 self.close()
             except Exception as e:
-                if logger:
-                    logger.error(f"Error during connection cleanup in __del__: {e}")
+                raise InterfaceError(
+                    driver_error=str(e),
+                    ddbc_error="Error during python connection cleanup"
+                )

mssql_python/cursor.py

@@ -17,6 +17,7 @@
 from mssql_python.helpers import check_error
 from mssql_python.logging_config import get_logger
 from mssql_python import ddbc_bindings
+from mssql_python.exceptions import InterfaceError
 from .row import Row
 
 logger = get_logger()
@@ -739,5 +740,7 @@ def __del__(self):
             try:
                 self.close()
             except Exception as e:
-                if logger:
-                    logger.error(f"Error closing cursor: {e}")
+                raise InterfaceError(
+                    driver_error=str(e),
+                    ddbc_error="Error during python connection cleanup"
+                )

mssql_python/logging_config.py

@@ -132,6 +132,7 @@ def get_logger(self):
             logging.Logger: The logger instance, or None if logging is not enabled.
         """
         if not self.enabled:
+            # If logging is not enabled, return None
             return None
         return self._logger
 
@@ -160,4 +161,10 @@ def get_logger():
     Returns:
         logging.Logger: The logger instance.
     """
-    return _manager.get_logger()
+    # Always return a logger instance, even if setup hasn't been called yet
+    # This ensures modules can get a logger reference that will work once setup is called
+    if _manager._logger is None:
+        # Return the logger that will be configured when setup() is called
+        # This logger won't output anything until handlers are added in setup()
+        return logging.getLogger("mssql_python")
+    return _manager._logger