chore: migrate to ts 5.7.3 (#35378)

Author: mainframev

change/@fluentui-api-docs-6e7e51f2-7e38-4132-842d-ceef171234ff.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "chore: bump tsdoc\" ",
+  "packageName": "@fluentui/api-docs",
+  "email": "vgenaev@gmail.com",
+  "dependentChangeType": "patch"
+}

change/@fluentui-eslint-plugin-react-components-656cfb11-2118-4718-a0a8-d7baad55f540.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "chore: update ts-eslint to 8.46.2",
+  "packageName": "@fluentui/eslint-plugin-react-components",
+  "email": "vgenaev@gmail.com",
+  "dependentChangeType": "patch"
+}

change/@fluentui-react-charts-e70733d5-7c7e-4b9a-bd93-90092ef47f6f.json

@@ -0,0 +1,7 @@
+{
+  "type": "none",
+  "comment": "chore: fix ts issues",
+  "packageName": "@fluentui/react-charts",
+  "email": "vgenaev@gmail.com",
+  "dependentChangeType": "none"
+}

package.json

@@ -67,8 +67,8 @@
     "@griffel/webpack-loader": "2.2.10",
     "@jest/reporters": "29.7.0",
     "@mdx-js/loader": "2.3.0",
-    "@microsoft/api-extractor": "7.49.1",
-    "@microsoft/api-extractor-model": "7.30.2",
+    "@microsoft/api-extractor": "7.51.0",
+    "@microsoft/api-extractor-model": "7.31.2",
     "@microsoft/eslint-plugin-sdl": "1.0.1",
     "@microsoft/load-themed-styles": "1.10.26",
     "@microsoft/loader-load-themed-styles": "2.0.17",
@@ -163,7 +163,8 @@
     "@types/webpack-hot-middleware": "2.25.9",
     "@types/yargs": "13.0.11",
     "@types/yargs-unparser": "2.0.1",
-    "@typescript-eslint/rule-tester": "8.38.0",
+    "@typescript-eslint/rule-tester": "8.46.2",
+    "@typescript-eslint/eslint-plugin": "^8.46.2",
     "autoprefixer": "10.2.1",
     "babel-jest": "29.7.0",
     "babel-loader": "9.1.3",
@@ -316,8 +317,8 @@
     "tslib": "2.8.1",
     "turndown": "7.2.0",
     "turndown-plugin-gfm": "1.0.2",
-    "typescript": "5.5.2",
-    "typescript-eslint": "8.38.0",
+    "typescript": "5.7.3",
+    "typescript-eslint": "8.46.2",
     "vite": "6.3.4",
     "webpack": "5.99.8",
     "webpack-bundle-analyzer": "4.10.1",
@@ -353,8 +354,8 @@
   },
   "resolutions": {
     "@types/jest-axe/axe-core": "4.7.2",
+    "@phenomnomnominal/tsquery": "6.1.3",
     "esbuild": "0.25.0",
-    "@microsoft/api-extractor/typescript": "5.5.2",
     "swc-loader": "^0.2.6",
     "prettier": "2.8.8",
     "puppeteer": "19.6.3",

packages/api-docs/package.json

@@ -21,7 +21,7 @@
     "@fluentui/scripts-tasks": "*"
   },
   "dependencies": {
-    "@microsoft/api-extractor-model": "7.30.2",
+    "@microsoft/api-extractor-model": "7.31.2",
     "@microsoft/tsdoc": "0.15.1",
     "fs-extra": "^8.1.0"
   }

packages/charts/react-charts/library/src/components/CommonComponents/CartesianChart.tsx

@@ -47,7 +47,7 @@ export const CartesianChart: React.FunctionComponent<ModifiedCartesianChartProps
   const yAxisElementSecondary = React.useRef<SVGSVGElement>();
   let margins: IMargins;
   const idForGraph: string = 'chart_';
-  let _reqID: number;
+  let _reqID: number | undefined;
   const _useRtl: boolean = useRtl();
   let _tickValues: (string | number)[];
   const titleMargin: number = 8;
@@ -146,7 +146,9 @@ export const CartesianChart: React.FunctionComponent<ModifiedCartesianChartProps
       setStartFromX(0);
     }
     return () => {
-      cancelAnimationFrame(_reqID);
+      if (_reqID !== undefined) {
+        cancelAnimationFrame(_reqID);
+      }
     };
   }, [props]);
 

packages/eslint-plugin/package.json

@@ -14,8 +14,8 @@
     "@griffel/eslint-plugin": "^2.0.0",
     "@rnx-kit/eslint-plugin": "^0.8.4",
     "@nx/eslint-plugin": "20.8.1",
-    "@typescript-eslint/type-utils": "^8.38.0",
-    "@typescript-eslint/utils": "^8.38.0",
+    "@typescript-eslint/type-utils": "^8.46.2",
+    "@typescript-eslint/utils": "^8.46.2",
     "eslint-config-airbnb": "^18.2.1",
     "eslint-config-prettier": "^10.1.8",
     "eslint-plugin-react-compiler": "0.0.0-experimental-a97cca1-20240529",
@@ -32,11 +32,12 @@
     "globals": "13.24.0",
     "jju": "^1.4.0",
     "minimatch": "^3.1.2",
-    "typescript-eslint": "^8.38.0"
+    "typescript-eslint": "^8.46.2",
+    "@typescript-eslint/eslint-plugin": "^8.46.2"
   },
   "peerDependencies": {
     "eslint": "^9.0.0",
-    "typescript": "^4.8.4"
+    "typescript": "^5.0.0"
   },
   "files": [
     "src"

packages/react-components/eslint-plugin-react-components/package.json

@@ -14,11 +14,11 @@
     "eslint-plugin-eslint-plugin": "6.4.0"
   },
   "dependencies": {
-    "@typescript-eslint/utils": "^8.38.0",
+    "@typescript-eslint/utils": "^8.46.2",
     "@swc/helpers": "^0.5.1"
   },
   "peerDependencies": {
-    "typescript-eslint": "^8.38.0",
+    "typescript-eslint": "^8.46.2",
     "eslint": "^8.0.0",
     "typescript": "^5.0.0"
   },

packages/react-components/react-utilities/src/hooks/useControllableState.test.ts

@@ -24,6 +24,7 @@ describe('useControllableState', () => {
     expect(result.current[0]).toBe(false);
 
     // this will cause console.error to be called
+    // @ts-expect-error - intentionally passing both state and defaultState to trigger error
     rerender({ defaultState: true, state: false, initialState: false });
     expect(result.current[0]).toBe(false);
     expect(consoleErrorSpy).toHaveBeenCalledTimes(1);

packages/react-components/react-utilities/src/trigger/applyTriggerPropsToChildren.test.tsx

@@ -3,9 +3,9 @@ import { render } from '@testing-library/react';
 import { applyTriggerPropsToChildren } from './applyTriggerPropsToChildren';
 import type { FluentTriggerComponent, TriggerProps } from './types';
 
-export const TestTrigger: React.FC<TriggerProps & { id?: string }> & FluentTriggerComponent = props => (
-  <>{props.children}</>
-);
+export const TestTrigger: React.FC<TriggerProps & { id?: string }> & FluentTriggerComponent = props => {
+  return props.children as React.ReactElement;
+};
 TestTrigger.displayName = 'TestTrigger';
 TestTrigger.isFluentTriggerComponent = true;