Skip to content

Commit 0409b2b

Browse files
committed
Address Copilot round 4: add PrintUsage on missing values, use ToUpperInvariant
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 59c5c0b commit 0409b2b

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

Samples/WindowsML/Shared/cpp/ArgumentParser.cpp

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ namespace Shared
4141
if (i + 1 >= arguments.size())
4242
{
4343
std::wcout << L"ERROR: --model requires a value.\n";
44+
PrintUsage();
4445
return false;
4546
}
4647
options.model_path = arguments[++i];
@@ -50,6 +51,7 @@ namespace Shared
5051
if (i + 1 >= arguments.size())
5152
{
5253
std::wcout << L"ERROR: --compiled_output requires a value.\n";
54+
PrintUsage();
5355
return false;
5456
}
5557
options.output_path = arguments[++i];
@@ -59,6 +61,7 @@ namespace Shared
5961
if (i + 1 >= arguments.size())
6062
{
6163
std::wcout << L"ERROR: --image_path requires a value.\n";
64+
PrintUsage();
6265
return false;
6366
}
6467
options.image_path = arguments[++i];
@@ -68,6 +71,7 @@ namespace Shared
6871
if (i + 1 >= arguments.size())
6972
{
7073
std::wcout << L"ERROR: --ep_policy requires a value.\n";
74+
PrintUsage();
7175
return false;
7276
}
7377
auto policy_str = arguments[++i];
@@ -108,6 +112,7 @@ namespace Shared
108112
if (i + 1 >= arguments.size())
109113
{
110114
std::wcout << L"ERROR: --perf_mode requires a value.\n";
115+
PrintUsage();
111116
return false;
112117
}
113118
std::wstring perf_mode_token = std::wstring(arguments[++i]);
@@ -135,6 +140,7 @@ namespace Shared
135140
if (i + 1 >= arguments.size())
136141
{
137142
std::wcout << L"ERROR: --ep_name requires a value.\n";
143+
PrintUsage();
138144
return false;
139145
}
140146
options.ep_name = arguments[++i];
@@ -144,6 +150,7 @@ namespace Shared
144150
if (i + 1 >= arguments.size())
145151
{
146152
std::wcout << L"ERROR: --device_type requires a value.\n";
153+
PrintUsage();
147154
return false;
148155
}
149156
std::wstring dt = std::wstring(arguments[++i]);

Samples/WindowsML/Shared/cs/ArgumentParser.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public static Options ParseOptions(string[] args)
6262
if (i + 1 < args.Length)
6363
{
6464
string policyStr = args[++i];
65-
switch (policyStr.ToUpper())
65+
switch (policyStr.ToUpperInvariant())
6666
{
6767
case "NPU":
6868
options.EpPolicy = ExecutionProviderDevicePolicy.PREFER_NPU;

0 commit comments

Comments
 (0)