Fix HammerDB/PostgreSQL: use hex password to avoid TCL parsing error (#686)

Base64 password contains + and = characters which break HammerDB 4.12's
TCL diset command argument parsing. Changed to hex encoding which
produces alphanumeric-only output across all three components that
share the SuperUserPassword:
- HammerDBExecutor
- PostgreSQLServerConfiguration
- SysbenchExecutor

All three must use the same encoding since they share the same
PostgreSQL credential.

This has been the sole cause of HammerDB parse failures since Mar 16
(~1700 errors/day).

Co-authored-by: Alex Williams-Ferreira <alexwill@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: 3 people

VERSION

@@ -1 +1 @@
-3.0.14
+3.0.15

src/VirtualClient/VirtualClient.Actions.FunctionalTests/MLPerfProfileTests.cs

@@ -16,6 +16,7 @@ namespace VirtualClient.Actions
 
     [TestFixture]
     [Category("Functional")]
+    [Ignore("MLPerf profiles archived - no longer in active profiles directory")]
     public class MLPerfProfileTests
     {
         private DependencyFixture mockFixture;

src/VirtualClient/VirtualClient.Actions.FunctionalTests/SuperBenchmarkProfileTests.cs

@@ -39,7 +39,7 @@ public void SuperBenchmarkWorkloadProfileParametersAreInlinedCorrectly(string pr
         }
 
         [Test]
-        [TestCase("SETUP-NVIDIA-A100.json")]
+        [TestCase("SETUP-GPU-NVIDIA-A100.json")]
         public async Task SuperBenchmarkWorkloadProfileExecutesTheExpectedDependenciesAndReboot(string profile)
         {
             List<string> expectedCommands = new List<string>
@@ -74,7 +74,7 @@ public async Task SuperBenchmarkWorkloadProfileExecutesTheExpectedDependenciesAn
         }
 
         [Test]
-        [TestCase("SETUP-NVIDIA-A100.json")]
+        [TestCase("SETUP-GPU-NVIDIA-A100.json")]
         public async Task SuperBenchmarkWorkloadProfileExecutesTheExpectedDependenciesAndWorkloadsAfterReboot(string profile)
         {
             IEnumerable<string> expectedCommands = this.GetProfileExpectedCommands(PlatformID.Unix);

src/VirtualClient/VirtualClient.Actions.UnitTests/HammerDB/HammerDBClientExecutorTests.cs

@@ -48,12 +48,12 @@ public async Task HammerDBClientExecutorRunsTheExpectedWorkloadCommand(PlatformI
 
             if (platform == PlatformID.Unix)
             {
-                expectedCommands.Add($"sudo python3 {this.fixture.PlatformSpecifics.Combine(this.mockPackagePath, "configure-workload-generator.py")} --workload tpcc --sqlServer postgresql --port 5432 --virtualUsers 1 --password [A-Za-z0-9+/=]+ --dbName hammerdbtest --hostIPAddress [0-9.]+ --warehouseCount 1 --duration 1");
+                expectedCommands.Add($"sudo python3 {this.fixture.PlatformSpecifics.Combine(this.mockPackagePath, "configure-workload-generator.py")} --workload tpcc --sqlServer postgresql --port 5432 --virtualUsers 1 --password [A-Fa-f0-9]+ --dbName hammerdbtest --hostIPAddress [0-9.]+ --warehouseCount 1 --duration 1");
                 expectedCommands.Add($"python3 {this.fixture.PlatformSpecifics.Combine(this.mockPackagePath, "run-workload.py")} --runTransactionsTCLFilePath runTransactions.tcl");
             }
             else
             {
-                expectedCommands.Add($"python3 {this.fixture.PlatformSpecifics.Combine(this.mockPackagePath, "configure-workload-generator.py")} --workload tpcc --sqlServer postgresql --port 5432 --virtualUsers 1 --password [A-Za-z0-9+/=]+ --dbName hammerdbtest --hostIPAddress [0-9.]+ --warehouseCount 1 --duration 1");
+                expectedCommands.Add($"python3 {this.fixture.PlatformSpecifics.Combine(this.mockPackagePath, "configure-workload-generator.py")} --workload tpcc --sqlServer postgresql --port 5432 --virtualUsers 1 --password [A-Fa-f0-9]+ --dbName hammerdbtest --hostIPAddress [0-9.]+ --warehouseCount 1 --duration 1");
                 expectedCommands.Add($"python3 {this.fixture.PlatformSpecifics.Combine(this.mockPackagePath, "run-workload.py")} --runTransactionsTCLFilePath runTransactions.tcl");
             }
 

src/VirtualClient/VirtualClient.Actions.UnitTests/HammerDB/HammerDBExecutorTests.cs

@@ -74,6 +74,25 @@ public void HammerDBPExecutorThrowsOnUnsupportedDistroAsync()
             }
         }
 
+        [Test]
+        public void SuperUserPasswordUsesHexEncodingWithNoSpecialCharacters()
+        {
+            using (TestHammerDBExecutor executor = new TestHammerDBExecutor(this.fixture.Dependencies, this.fixture.Parameters))
+            {
+                string password = executor.SuperUserPassword;
+
+                // Password must be hex-encoded (alphanumeric only) to avoid breaking
+                // HammerDB TCL diset command argument parsing.
+                Assert.IsTrue(System.Text.RegularExpressions.Regex.IsMatch(password, "^[A-Fa-f0-9]+$"),
+                    $"SuperUserPassword must be hex-encoded (alphanumeric only). Got: {password}");
+
+                // Must not contain Base64 special characters that break TCL parsing
+                Assert.IsFalse(password.Contains("+"), "Password must not contain '+' (breaks TCL parsing)");
+                Assert.IsFalse(password.Contains("="), "Password must not contain '=' (breaks TCL parsing)");
+                Assert.IsFalse(password.Contains("/"), "Password must not contain '/' (breaks TCL parsing)");
+            }
+        }
+
         private class TestHammerDBExecutor : HammerDBExecutor
         {
             public TestHammerDBExecutor(IServiceCollection dependencies, IDictionary<string, IConvertible> parameters = null)

src/VirtualClient/VirtualClient.Actions/HammerDB/HammerDBExecutor.cs

@@ -98,7 +98,7 @@ public string SuperUserPassword
             get
             {
                 byte[] hashBytes = SHA256.HashData(Encoding.UTF8.GetBytes("default"));
-                return Convert.ToBase64String(hashBytes);
+                return Convert.ToHexString(hashBytes);
             }
         }
 

src/VirtualClient/VirtualClient.Actions/Sysbench/SysbenchExecutor.cs

@@ -170,7 +170,7 @@ public string SuperUserPassword
             get
             {
                 byte[] hashBytes = SHA256.HashData(Encoding.UTF8.GetBytes("default"));
-                return Convert.ToBase64String(hashBytes);
+                return Convert.ToHexString(hashBytes);
             }
         }
 

src/VirtualClient/VirtualClient.Dependencies/PostgreSQLServer/PostgreSQLServerConfiguration.cs

@@ -108,7 +108,7 @@ public string SuperUserPassword
             get
             {
                 byte[] hashBytes = SHA256.HashData(Encoding.UTF8.GetBytes("default"));
-                return Convert.ToBase64String(hashBytes);
+                return Convert.ToHexString(hashBytes);
             }
         }