Skip to content

Commit a87c9c8

Browse files
committed
fix: remove not implemented export route
1 parent f22ba8e commit a87c9c8

5 files changed

Lines changed: 13 additions & 44 deletions

File tree

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,6 @@ php artisan vendor:publish --tag="request-analytics-views"
135135
- 🚀 **High Performance** - Built-in caching and optimized database queries
136136
- 📱 **Device Detection** - Track browsers, operating systems, and devices
137137
- 👥 **Visitor Tracking** - Unique visitor identification with cookie-based tracking
138-
- 📤 **Export Data** - Export analytics data to CSV or JSON formats
139138
- 🔌 **REST API** - Full-featured API for programmatic access
140139
- 🧹 **Auto Cleanup** - Automatic data pruning to manage database size
141140

routes/api.php

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
<?php
2+
3+
use Illuminate\Support\Facades\Route;
4+
use MeShaon\RequestAnalytics\Controllers\Api\AnalyticsApiController;
5+
6+
Route::middleware(['api', 'auth:sanctum', 'request-analytics.access'])
7+
->prefix('api/v1/analytics')
8+
->name('request-analytics.api.')
9+
->group(function () {
10+
Route::get('/overview', [AnalyticsApiController::class, 'overview'])->name('overview');
11+
Route::get('/visitors', [AnalyticsApiController::class, 'visitors'])->name('visitors');
12+
Route::get('/page-views', [AnalyticsApiController::class, 'pageViews'])->name('page-views');
13+
});

routes/web.php

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,8 @@
11
<?php
22

33
use Illuminate\Support\Facades\Route;
4-
use MeShaon\RequestAnalytics\Controllers\Api\AnalyticsApiController;
54
use MeShaon\RequestAnalytics\Controllers\RequestAnalyticsController;
65

76
Route::middleware(['web', 'auth', 'request-analytics.access'])
87
->get(config('request-analytics.route.pathname'), [RequestAnalyticsController::class, 'show'])
98
->name(config('request-analytics.route.name'));
10-
11-
Route::middleware(['api', 'auth:sanctum', 'request-analytics.access'])
12-
->prefix('api/v1/analytics')
13-
->name('request-analytics.api.')
14-
->group(function () {
15-
Route::get('/overview', [AnalyticsApiController::class, 'overview'])->name('overview');
16-
Route::get('/visitors', [AnalyticsApiController::class, 'visitors'])->name('visitors');
17-
Route::get('/page-views', [AnalyticsApiController::class, 'pageViews'])->name('page-views');
18-
Route::post('/export', [AnalyticsApiController::class, 'export'])->name('export');
19-
});

src/Controllers/Api/AnalyticsApiController.php

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -103,23 +103,6 @@ public function pageViews(Request $request): JsonResponse
103103
]);
104104
}
105105

106-
public function export(Request $request): JsonResponse
107-
{
108-
$request->validate([
109-
'format' => 'required|in:csv,json',
110-
'date_range' => 'integer|min:1|max:365',
111-
'type' => 'required|in:overview,visitors,page_views',
112-
]);
113-
114-
// This would typically queue a job for large exports
115-
// For now, we'll return a simple response
116-
return response()->json([
117-
'success' => true,
118-
'message' => 'Export queued successfully',
119-
'job_id' => uniqid('export_'),
120-
]);
121-
}
122-
123106
protected function getDateRange(Request $request): array
124107
{
125108
if ($request->has('start_date') && $request->has('end_date')) {

tests/Feature/ApiTest.php

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -68,18 +68,3 @@
6868
$response->assertStatus(422)
6969
->assertJsonValidationErrors(['date_range']);
7070
});
71-
72-
it('queues export job', function () {
73-
$response = $this->postJson('/api/v1/analytics/export', [
74-
'format' => 'csv',
75-
'type' => 'overview',
76-
'date_range' => 30,
77-
]);
78-
79-
$response->assertStatus(200)
80-
->assertJsonStructure([
81-
'success',
82-
'message',
83-
'job_id',
84-
]);
85-
});

0 commit comments

Comments
 (0)