Skip to content

Commit 711419a

Browse files
committed
fix: tests
1 parent 1cdda7e commit 711419a

2 files changed

Lines changed: 21 additions & 27 deletions

File tree

tests/Feature/Api/AnalyticsApiTest.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@ public function it_returns_overview_data_with_default_parameters(): void
2121
->assertJsonStructure([
2222
'data' => [
2323
'summary' => [
24-
'total_views',
25-
'unique_visitors',
26-
'unique_sessions',
27-
'avg_response_time',
24+
'views',
25+
'visitors',
26+
'bounce_rate',
27+
'average_visit_time',
2828
],
2929
'chart',
3030
'top_pages',
@@ -132,8 +132,8 @@ public function it_returns_empty_overview_data(): void
132132
->assertJson([
133133
'data' => [
134134
'summary' => [
135-
'total_views' => 0,
136-
'unique_visitors' => 0,
135+
'views' => 0,
136+
'visitors' => 0,
137137
],
138138
],
139139
]);

tests/Unit/AnalyticsServiceTest.php

Lines changed: 15 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -94,25 +94,27 @@ public function it_gets_summary_data(): void
9494
]);
9595

9696
$query = RequestAnalytics::query();
97-
$result = $this->service->getSummary($query);
97+
$dateRange = $this->service->getDateRange(['date_range' => 30]);
98+
$result = $this->service->getSummary($query, $dateRange);
9899

99100
$this->assertIsArray($result);
100-
$this->assertEquals(8, $result['total_views']);
101-
$this->assertEquals(2, $result['unique_visitors']);
102-
$this->assertEquals(2, $result['unique_sessions']);
103-
$this->assertEquals(137.5, $result['avg_response_time']);
101+
$this->assertEquals(8, $result['views']);
102+
$this->assertEquals(2, $result['visitors']);
103+
$this->assertArrayHasKey('bounce_rate', $result);
104+
$this->assertArrayHasKey('average_visit_time', $result);
104105
}
105106

106107
#[Test]
107108
public function it_gets_summary_with_no_data(): void
108109
{
109110
$query = RequestAnalytics::query();
110-
$result = $this->service->getSummary($query);
111+
$dateRange = $this->service->getDateRange(['date_range' => 30]);
112+
$result = $this->service->getSummary($query, $dateRange);
111113

112-
$this->assertEquals(0, $result['total_views']);
113-
$this->assertEquals(0, $result['unique_visitors']);
114-
$this->assertEquals(0, $result['unique_sessions']);
115-
$this->assertEquals(0, $result['avg_response_time']);
114+
$this->assertEquals(0, $result['views']);
115+
$this->assertEquals(0, $result['visitors']);
116+
$this->assertArrayHasKey('bounce_rate', $result);
117+
$this->assertArrayHasKey('average_visit_time', $result);
116118
}
117119

118120
#[Test]
@@ -210,7 +212,7 @@ public function it_gets_browsers_data(): void
210212
RequestAnalytics::factory()->create(['browser' => null]);
211213

212214
$query = RequestAnalytics::query();
213-
$result = $this->service->getBrowsers($query);
215+
$result = $this->service->getBrowsersData($query, false);
214216

215217
$this->assertIsArray($result);
216218
$this->assertCount(2, $result);
@@ -225,7 +227,7 @@ public function it_gets_browsers_data_with_percentages(): void
225227
RequestAnalytics::factory()->count(3)->create(['browser' => 'Firefox']);
226228

227229
$query = RequestAnalytics::query();
228-
$result = $this->service->getBrowsers($query, true);
230+
$result = $this->service->getBrowsersData($query, true);
229231

230232
$this->assertIsArray($result);
231233
$this->assertEquals(70.0, $result[0]['percentage']);
@@ -269,7 +271,7 @@ public function it_gets_countries_data(): void
269271
RequestAnalytics::factory()->create(['country' => null]);
270272

271273
$query = RequestAnalytics::query();
272-
$result = $this->service->getCountries($query);
274+
$result = $this->service->getCountriesData($query, false);
273275

274276
$this->assertIsArray($result);
275277
$this->assertCount(2, $result);
@@ -373,14 +375,6 @@ public function it_gets_page_views_with_path_filter(): void
373375
$this->assertEquals(5, $result->total());
374376
}
375377

376-
#[Test]
377-
public function it_gets_correct_date_expression_for_sqlite(): void
378-
{
379-
$result = $this->service->getDateExpression('visited_at');
380-
381-
$this->assertEquals('DATE(visited_at)', $result);
382-
}
383-
384378
#[Test]
385379
public function it_gets_correct_domain_expression_for_sqlite(): void
386380
{

0 commit comments

Comments
 (0)