Skip to content

Commit a7419b5

Browse files
committed
Removed the default values as they are now ineffective with proper defaults set for each pod type separately.
1 parent 02ae2ff commit a7419b5

File tree

4 files changed

+3
-16
lines changed

4 files changed

+3
-16
lines changed

templates/deployment-sidekiq.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ spec:
122122
mountPath: /opt/mastodon/public/system
123123
{{- end }}
124124
resources:
125-
{{- toYaml (default (default $context.Values.resources $context.Values.mastodon.sidekiq.resources) .resources) | nindent 12 }}
125+
{{- toYaml (default $context.Values.mastodon.sidekiq.resources .resources) | nindent 12 }}
126126
{{- with $context.Values.nodeSelector }}
127127
nodeSelector:
128128
{{- toYaml . | nindent 8 }}

templates/deployment-streaming.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ spec:
7070
httpGet:
7171
path: /api/v1/streaming/health
7272
port: streaming
73-
{{- with (default .Values.resources .Values.mastodon.streaming.resources) }}
73+
{{- with .Values.mastodon.streaming.resources }}
7474
resources:
7575
{{- toYaml . | nindent 12 }}
7676
{{- end }}

templates/deployment-web.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ spec:
126126
port: http
127127
failureThreshold: 30
128128
periodSeconds: 5
129-
{{- with (default .Values.resources .Values.mastodon.web.resources) }}
129+
{{- with .Values.mastodon.web.resources }}
130130
resources:
131131
{{- toYaml . | nindent 12 }}
132132
{{- end }}

values.yaml

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -443,19 +443,6 @@ revisionPodAnnotation: true
443443
# The annotations set with jobAnnotations will be added to all job pods.
444444
jobAnnotations: {}
445445

446-
# -- Default resources for all Deployments and jobs unless overwritten
447-
resources: {}
448-
# We usually recommend not to specify default resources and to leave this as a conscious
449-
# choice for the user. This also increases chances charts run on environments with little
450-
# resources, such as Minikube. If you do want to specify resources, uncomment the following
451-
# lines, adjust them as necessary, and remove the curly braces after 'resources:'.
452-
# limits:
453-
# cpu: 100m
454-
# memory: 128Mi
455-
# requests:
456-
# cpu: 100m
457-
# memory: 128Mi
458-
459446
# @ignored
460447
nodeSelector: {}
461448

0 commit comments

Comments
 (0)