Skip to content

Commit 98818d6

Browse files
Asheesh GuptaAsheesh Gupta
authored andcommitted
fix: use correct RBAC scopes for incident delete and read endpoints
- Change delete/bulk-delete/delete-alerts endpoints from write:incident to delete:incident to follow CRUD scope conventions - Fix read:incidents (plural) typo to read:incident (singular) for consistency with all other scope definitions Closes #5363
1 parent b2eabaf commit 98818d6

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

keep/api/routes/incidents.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -427,7 +427,7 @@ def update_incident(
427427
def bulk_delete_incidents(
428428
incident_ids: List[UUID] = Body(..., embed=True),
429429
authenticated_entity: AuthenticatedEntity = Depends(
430-
IdentityManagerFactory.get_auth_verifier(["write:incident"])
430+
IdentityManagerFactory.get_auth_verifier(["delete:incident"])
431431
),
432432
pusher_client: Pusher | None = Depends(get_pusher_client),
433433
session: Session = Depends(get_session),
@@ -445,7 +445,7 @@ def bulk_delete_incidents(
445445
def delete_incident(
446446
incident_id: UUID,
447447
authenticated_entity: AuthenticatedEntity = Depends(
448-
IdentityManagerFactory.get_auth_verifier(["write:incident"])
448+
IdentityManagerFactory.get_auth_verifier(["delete:incident"])
449449
),
450450
pusher_client: Pusher | None = Depends(get_pusher_client),
451451
session: Session = Depends(get_session),
@@ -549,7 +549,7 @@ def get_incident_alerts(
549549
offset: int = 0,
550550
include_unlinked: bool = False,
551551
authenticated_entity: AuthenticatedEntity = Depends(
552-
IdentityManagerFactory.get_auth_verifier(["read:incidents"])
552+
IdentityManagerFactory.get_auth_verifier(["read:incident"])
553553
),
554554
) -> AlertWithIncidentLinkMetadataPaginatedResultsDto:
555555
tenant_id = authenticated_entity.tenant_id
@@ -601,7 +601,7 @@ def get_future_incidents_for_an_incident(
601601
limit: int = 25,
602602
offset: int = 0,
603603
authenticated_entity: AuthenticatedEntity = Depends(
604-
IdentityManagerFactory.get_auth_verifier(["read:incidents"])
604+
IdentityManagerFactory.get_auth_verifier(["read:incident"])
605605
),
606606
) -> IncidentsPaginatedResultsDto:
607607
tenant_id = authenticated_entity.tenant_id
@@ -653,7 +653,7 @@ def get_incident_workflows(
653653
limit: int = 25,
654654
offset: int = 0,
655655
authenticated_entity: AuthenticatedEntity = Depends(
656-
IdentityManagerFactory.get_auth_verifier(["read:incidents"])
656+
IdentityManagerFactory.get_auth_verifier(["read:incident"])
657657
),
658658
) -> WorkflowExecutionsPaginatedResultsDto:
659659
"""
@@ -718,7 +718,7 @@ def delete_alerts_from_incident(
718718
incident_id: UUID,
719719
fingerprints: List[str],
720720
authenticated_entity: AuthenticatedEntity = Depends(
721-
IdentityManagerFactory.get_auth_verifier(["write:incident"])
721+
IdentityManagerFactory.get_auth_verifier(["delete:incident"])
722722
),
723723
session=Depends(get_session),
724724
pusher_client: Pusher | None = Depends(get_pusher_client),

0 commit comments

Comments
 (0)