You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jun 25, 2024. It is now read-only.
I believe the current implementation of which-key--next-page-hint could be improved. There are two issues with it.
If help-char (C-h) is bound under the current prefix, then pressing C-h will invoke the binding and not which-key-C-h-dispatch, while the hint still reads [C-h paging/help],
no hint is displayed for C-h- prefix at all, even if we have manually bound some key to which-key-C-h-dispatch there.
I've made a crude prototype that attempts to display a hint with keys that would actually work under the given prefix.
C-x- -> [C-h or <f1> or ? -> paging/help] as C-h is not bound under this prefix in our configuration,
C-w--> [<f1> or ? -> paging/help] as C-h is bound under this prefix in our configuration,
C-h- -> [<f5> -> paging/help] as we have bound C-h <f5> to which-key-C-h-dispatch in our configuration.
One remaining issue with my prototype is that a hint will be still displayed for evil prefixes while it shouldn't, as it is not possible to make any binding to which-key-C-h-dispatch there.
I believe the current implementation of
which-key--next-page-hintcould be improved. There are two issues with it.help-char(C-h) is bound under the current prefix, then pressingC-hwill invoke the binding and notwhich-key-C-h-dispatch, while the hint still reads [C-h paging/help],C-h-prefix at all, even if we have manually bound some key towhich-key-C-h-dispatchthere.I've made a crude prototype that attempts to display a hint with keys that would actually work under the given prefix.
Now we get nice hints:
C-x--> [C-h or <f1> or ? -> paging/help] asC-his not bound under this prefix in our configuration,C-w--> [<f1> or ? -> paging/help] asC-his bound under this prefix in our configuration,C-h--> [<f5> -> paging/help] as we have boundC-h <f5>towhich-key-C-h-dispatchin our configuration.One remaining issue with my prototype is that a hint will be still displayed for evil prefixes while it shouldn't, as it is not possible to make any binding to
which-key-C-h-dispatchthere.