Address AI review findings

- Make Expected field required (non-pointer value) in SpecNetworkInterface
- Add create verb to servernetworkconfigs RBAC marker

Author: xkonni

api/v1alpha1/servernetworkconfig_types.go

@@ -31,8 +31,8 @@ type SpecNetworkInterface struct {
 	MACAddress string `json:"macAddress"`
 
 	// Expected holds the expected switch connectivity for this interface.
-	// +optional
-	Expected *ExpectedNetworkDetails `json:"expected,omitempty"`
+	// +required
+	Expected ExpectedNetworkDetails `json:"expected"`
 }
 
 // ExpectedNetworkDetails holds the expected switch connectivity for a network interface.

api/v1alpha1/zz_generated.deepcopy.go

@@ -86,6 +86,7 @@ spec:
                         source.
                       type: string
                   required:
+                  - expected
                   - macAddress
                   - name
                   type: object

config/crd/bases/metal.ironcore.dev_servernetworkconfigs.yaml

@@ -20,7 +20,7 @@ spec:
     shortNames:
     - snc
     singular: servernetworkconfig
-  scope: Namespaced
+  scope: Cluster
   versions:
   - additionalPrinterColumns:
     - jsonPath: .spec.serverRef.name
@@ -92,6 +92,7 @@ spec:
                         source.
                       type: string
                   required:
+                  - expected
                   - macAddress
                   - name
                   type: object

dist/chart/templates/crd/metal.ironcore.dev_servernetworkconfigs.yaml

@@ -126,6 +126,7 @@ rules:
   resources:
   - servernetworkconfigs
   verbs:
+  - create
   - get
   - list
   - patch