DFU Runtime declares DFU version 1.0.1 not 1.1?

[morse-cedricvandenbergh]

Hi,

Am I correct in thinking tinyUSB supports DFU 1.1? If so, should the descriptor below not be advertising 0x0110 (i.e. 1.1) instaed of 0x0101 (1.0.1)?

// DFU runtime descriptor
// Interface number, string index, attributes, detach timeout, transfer size
#define TUD_DFU_RT_DESCRIPTOR(_itfnum, _stridx, _attr, _timeout, _xfer_size) \
  /* Interface */ \
  9, TUSB_DESC_INTERFACE, _itfnum, 0, 0, TUD_DFU_APP_CLASS, TUD_DFU_APP_SUBCLASS, DFU_PROTOCOL_RT, _stridx, \
  /* Function */ \
  9, DFU_DESC_FUNCTIONAL, _attr, U16_TO_U8S_LE(_timeout), U16_TO_U8S_LE(_xfer_size), U16_TO_U8S_LE(0x0101)

See section 4.1.3 of https://www.usb.org/sites/default/files/DFU_1.1.pdf and the following from section 9.6.1 from the USB 2.0 specification

The bcdUSB field contains a BCD version number. The value of the bcdUSB field is 0xJJMN for version
JJ.M.N (JJ – major version number, M – minor version number, N – sub-minor version number), e.g.,
version 2.1.3 is represented with value 0x0213 and version 2.0 is represented with a value of 0x0200.

Thanks,

Cedric

[HiFiPhile]

I think you are right from a first look.

[morse-cedricvandenbergh]

Thanks. In that case I'll raise a bug and implement a trivial fix in the next few days.

[hathach]

should be fixed by #3480

[morse-cedricvandenbergh]

Thanks.