remove unused ok/error wrapper from appDeploymentDocumentHashes

Author: adambenhassen

integration-tests/tests/api/app-deployments.spec.ts

@@ -5226,14 +5226,7 @@ const GetExistingDocumentHashes = graphql(`
     $hashes: [String!]!
   ) {
     target(reference: { bySelector: $targetSelector }) {
-      appDeploymentDocumentHashes(appName: $appName, hashes: $hashes) {
-        ok {
-          hashes
-        }
-        error {
-          message
-        }
-      }
+      appDeploymentDocumentHashes(appName: $appName, hashes: $hashes)
     }
   }
 `);
@@ -5657,9 +5650,10 @@ test('appDeploymentDocumentHashes returns existing hashes for delta upload', asy
     authToken: token.secret,
   }).then(res => res.expectNoGraphQLErrors());
 
-  expect(targetResult?.appDeploymentDocumentHashes.ok?.hashes).toContain(hash1);
-  expect(targetResult?.appDeploymentDocumentHashes.ok?.hashes).toContain(hash2);
-  expect(targetResult?.appDeploymentDocumentHashes.ok?.hashes?.length).toBe(2);
+  expect(targetResult?.appDeploymentDocumentHashes).toContain(hash1);
+  expect(targetResult?.appDeploymentDocumentHashes).toContain(hash2);
+  expect(targetResult?.appDeploymentDocumentHashes).not.toContain('nonexistent-hash');
+  expect(targetResult?.appDeploymentDocumentHashes?.length).toBe(2);
 });
 
 test('v2 format prevents hash collision by rejecting non-sha256 hashes', async () => {
@@ -5858,7 +5852,7 @@ test('v2 format enables cross-version document sharing', async () => {
     authToken: token.secret,
   }).then(res => res.expectNoGraphQLErrors());
 
-  expect(targetResult?.appDeploymentDocumentHashes.ok?.hashes).toContain(sharedHash);
+  expect(targetResult?.appDeploymentDocumentHashes).toContain(sharedHash);
 
   // Add the same document to v2.0.0 (should succeed, uses shared storage)
   const { addDocumentsToAppDeployment } = await execute({
@@ -6007,6 +6001,5 @@ test('appDeploymentDocumentHashes returns empty array for app with no previous d
   }).then(res => res.expectNoGraphQLErrors());
 
   // Should return empty array, not error
-  expect(targetResult?.appDeploymentDocumentHashes.ok?.hashes).toEqual([]);
-  expect(targetResult?.appDeploymentDocumentHashes.error).toBeNull();
+  expect(targetResult?.appDeploymentDocumentHashes).toEqual([]);
 });

packages/libraries/cli/src/commands/app/create.ts

@@ -196,19 +196,15 @@ export default class AppCreate extends Command<typeof AppCreate> {
         },
       });
 
-      if (hashesResult.target?.appDeploymentDocumentHashes.error) {
+      if (!hashesResult.target) {
         this.logWarning(
-          `Could not fetch existing document hashes: ${hashesResult.target.appDeploymentDocumentHashes.error.message}. Delta optimization disabled.`,
+          `Target not found when fetching existing hashes. Delta optimization disabled.`,
         );
-      } else if (hashesResult.target?.appDeploymentDocumentHashes.ok?.hashes) {
-        existingHashes = new Set(hashesResult.target.appDeploymentDocumentHashes.ok.hashes);
+      } else {
+        existingHashes = new Set(hashesResult.target.appDeploymentDocumentHashes);
         if (flags.showTiming) {
           this.log(`Found ${existingHashes.size} existing documents (will skip)`);
         }
-      } else if (!hashesResult.target) {
-        this.logWarning(
-          `Target not found when fetching existing hashes. Delta optimization disabled.`,
-        );
       }
     }
 
@@ -370,14 +366,7 @@ const GetExistingDocumentHashesQuery = graphql(/* GraphQL */ `
     $hashes: [String!]!
   ) {
     target(reference: $target) {
-      appDeploymentDocumentHashes(appName: $appName, hashes: $hashes) {
-        ok {
-          hashes
-        }
-        error {
-          message
-        }
-      }
+      appDeploymentDocumentHashes(appName: $appName, hashes: $hashes)
     }
   }
 `);

packages/services/api/src/modules/app-deployments/module.graphql.ts

@@ -141,23 +141,7 @@ export default gql`
     appDeploymentDocumentHashes(
       appName: String!
       hashes: [String!]!
-    ): AppDeploymentDocumentHashesResult!
-  }
-
-  type AppDeploymentDocumentHashesResult {
-    ok: AppDeploymentDocumentHashesOk
-    error: AppDeploymentDocumentHashesError
-  }
-
-  type AppDeploymentDocumentHashesOk {
-    """
-    List of document hashes that already exist for this app.
-    """
-    hashes: [String!]!
-  }
-
-  type AppDeploymentDocumentHashesError implements Error {
-    message: String!
+    ): [String!]!
   }
 
   extend type Mutation {

packages/services/api/src/modules/app-deployments/providers/app-deployments-manager.ts

@@ -285,9 +285,7 @@ export class AppDeploymentsManager {
     targetId: string;
     appName: string;
     hashes: readonly string[];
-  }): Promise<
-    { type: 'success'; hashes: string[] } | { type: 'error'; error: { message: string } }
-  > {
+  }): Promise<string[]> {
     await this.session.assertPerformAction({
       action: 'appDeployment:create',
       organizationId: args.organizationId,
@@ -299,15 +297,10 @@ export class AppDeploymentsManager {
       },
     });
 
-    const hashes = await this.appDeployments.getExistingDocumentHashes({
+    return this.appDeployments.getExistingDocumentHashes({
       targetId: args.targetId,
       appName: args.appName,
       hashes: args.hashes,
     });
-
-    return {
-      type: 'success',
-      hashes,
-    };
   }
 }

packages/services/api/src/modules/app-deployments/resolvers/Target.ts

@@ -57,29 +57,13 @@ export const Target: Pick<
       },
     });
   },
-  appDeploymentDocumentHashes: async (target, args, { injector }) => {
-    const result = await injector.get(AppDeploymentsManager).getExistingDocumentHashes({
+  appDeploymentDocumentHashes: (target, args, { injector }) => {
+    return injector.get(AppDeploymentsManager).getExistingDocumentHashes({
       organizationId: target.orgId,
       projectId: target.projectId,
       targetId: target.id,
       appName: args.appName,
       hashes: args.hashes,
     });
-
-    if (result.type === 'error') {
-      return {
-        ok: null,
-        error: {
-          message: result.error.message,
-        },
-      };
-    }
-
-    return {
-      ok: {
-        hashes: result.hashes,
-      },
-      error: null,
-    };
   },
 };