Report download unavailable and 'reports' directory created with owner as root

[duncangreene]

Describe the bug
Strange one... A colleague ran a test on a device and is encountering the below when attempting to download the report file(s).

Corresponding line in Testrun output.

See below ls -l.

I did wonder whether case sensitivity/similarity of device names thus directory names may be a contributor somewhere along the line? The testrun process was started as ossadmin using sudo testrun and has been running for a number of days with other reports accessible without issue.

Interestingly, even after suitable chown -R of the affected reports directory...

...the report(s) are still unavailable for download.

Error logs
This is the reports directory, containing 2 tests. The first one (that colleague was trying to initially download above), and a second one that should contain more useful info in the testrun.log file.

reports.zip

Environment (please provide the following information about your setup):

• Version: 2.1

Additional context
Only modifications from official 2.1 release are as below.

• resources/test_packs/qualification.json (Set tests to excluded/recommended/informational as appropriate)
• resources/devices/device_profile.json (Add custom questions)

[duncangreene]

For the avoidance of doubt in case the similarity in directory names is a cause of concern, the two devices/directories do relate to two completely separate physical Tridium JACE 8000's with 2 entirely different configurations/ports open/etc.

[duncangreene]

We were able to recreate the root issue by doing the following.

1. Add device with Manufacturer as "Delta".
2. Run test on device and let it complete.
3. Edit the device and change Manufacturer to "Delta Controls".
4. Run test on device and let it complete.

You can see the root ownership in the below comparison of an unedited (Eurotech) and edited (Delta Controls) device folder.

[jboddey]

The solution here would be to set the device folder name to the MAC address. However, we went with Manufacturer and Model so that it is more readable.

[jboddey]

To allow it to remain readable, we will append the MAC address to the folder name (keeping it unique). This should then fix the issue you are facing.

[duncangreene]

To allow it to remain readable, we will append the MAC address to the folder name (keeping it unique). This should then fix the issue you are facing.

@jboddey just for the avoidance of doubt, is this to cover more the question of #1094?

This issue specifically relates to the handling of post-test device renaming (Manufacturer or Model) and folder ownership/download issues. Presumably the same issue will manifest itself if post-device addition MAC address changes are made also.

[duncangreene]

Just confirming that the root issue is still present in 2.2.

The above was achieved by following similar steps as already posted here, although in this case step 2 was not conducted (i.e. no test is required to be carried out first).

[hitnik]

The issue has been reported 422739482

[Aksinnia-Dzenisenka]

Hi! Thank you for reporting the issue.

Changing Manufacturer/Model post-test is not allowed to avoid results manipulation.

It is possible to add functionality to download old reports after the manufacturer name was changed, but old reports should have the previous manufacturer name.