Commit fd6ae4c
authored
Tensor-parallel: Fix delayed AllReduce on Gemma-4 MoE (#22129)
* Fix delayed AllReduce on Gemma-4 MoE
Skip forward past nodes that don't consume the current one, and allow a chain of MULs.
* Check for all sources before skipping nodes
* Address review comments1 parent fb19f94 commit fd6ae4c
1 file changed
Lines changed: 38 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1683 | 1683 | | |
1684 | 1684 | | |
1685 | 1685 | | |
| 1686 | + | |
| 1687 | + | |
| 1688 | + | |
| 1689 | + | |
| 1690 | + | |
| 1691 | + | |
| 1692 | + | |
| 1693 | + | |
| 1694 | + | |
| 1695 | + | |
| 1696 | + | |
| 1697 | + | |
| 1698 | + | |
| 1699 | + | |
| 1700 | + | |
| 1701 | + | |
| 1702 | + | |
| 1703 | + | |
| 1704 | + | |
| 1705 | + | |
| 1706 | + | |
| 1707 | + | |
| 1708 | + | |
| 1709 | + | |
| 1710 | + | |
| 1711 | + | |
| 1712 | + | |
| 1713 | + | |
| 1714 | + | |
| 1715 | + | |
1686 | 1716 | | |
1687 | 1717 | | |
1688 | 1718 | | |
| |||
1697 | 1727 | | |
1698 | 1728 | | |
1699 | 1729 | | |
1700 | | - | |
1701 | | - | |
1702 | | - | |
1703 | | - | |
| 1730 | + | |
| 1731 | + | |
| 1732 | + | |
| 1733 | + | |
| 1734 | + | |
| 1735 | + | |
1704 | 1736 | | |
1705 | 1737 | | |
1706 | 1738 | | |
1707 | 1739 | | |
1708 | 1740 | | |
1709 | 1741 | | |
1710 | 1742 | | |
| 1743 | + | |
| 1744 | + | |
1711 | 1745 | | |
1712 | 1746 | | |
1713 | 1747 | | |
| |||
0 commit comments