cmd: fix tests with nicediff function and avoid non-constant format string in call to (*testing.common).Logf

Author: vicky-sunshine

cmd/geth/logging_test.go

@@ -91,7 +91,7 @@ func testConsoleLogging(t *testing.T, format string, tStart, tEnd int) {
 		have = censor(have, tStart, tEnd)
 		want = censor(want, tStart, tEnd)
 		if have != want {
-			t.Logf(nicediff([]byte(have), []byte(want)))
+			t.Logf("%s", nicediff([]byte(have), []byte(want)))
 			t.Fatalf("format %v, line %d\nhave %v\nwant %v", format, i, have, want)
 		}
 	}
@@ -142,7 +142,7 @@ func TestJsonLogging(t *testing.T) {
 		}
 		if !bytes.Equal(have, want) {
 			// show an intelligent diff
-			t.Logf(nicediff(have, want))
+			t.Logf("%s", nicediff(have, want))
 			t.Errorf("file content wrong")
 		}
 	}
@@ -211,7 +211,7 @@ func TestFileOut(t *testing.T) {
 	}
 	if !bytes.Equal(have, want) {
 		// show an intelligent diff
-		t.Logf(nicediff(have, want))
+		t.Logf("%s", nicediff(have, want))
 		t.Errorf("file content wrong")
 	}
 }
@@ -231,7 +231,7 @@ func TestRotatingFileOut(t *testing.T) {
 	}
 	if !bytes.Equal(have, want) {
 		// show an intelligent diff
-		t.Logf(nicediff(have, want))
+		t.Logf("%s", nicediff(have, want))
 		t.Errorf("file content wrong")
 	}
 }