fix(menubar): use numeric version comparison for update check

iamtoruk · iamtoruk · commit 12f0833befb8 · 2026-04-19T16:33:52.000-07:00
Compare versions with .orderedDescending instead of != to prevent
showing update button when installed version is newer than cached.
diff --git a/mac/Sources/CodeBurnMenubar/Data/UpdateChecker.swift b/mac/Sources/CodeBurnMenubar/Data/UpdateChecker.swift
@@ -18,7 +18,8 @@ final class UpdateChecker {
         let current = currentVersion
         let normalizedLatest = latest.hasPrefix("v") ? String(latest.dropFirst()) : latest
         let normalizedCurrent = current.hasPrefix("v") ? String(current.dropFirst()) : current
-        return !normalizedCurrent.isEmpty && normalizedCurrent != "dev" && normalizedLatest != normalizedCurrent
+        guard !normalizedCurrent.isEmpty && normalizedCurrent != "dev" else { return false }
+        return normalizedLatest.compare(normalizedCurrent, options: .numeric) == .orderedDescending
     }
 
     var currentVersion: String {

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,8 @@ final class UpdateChecker {`
`18`	`18`	`let current = currentVersion`
`19`	`19`	`let normalizedLatest = latest.hasPrefix("v") ? String(latest.dropFirst()) : latest`
`20`	`20`	`let normalizedCurrent = current.hasPrefix("v") ? String(current.dropFirst()) : current`
`21`		`- return !normalizedCurrent.isEmpty && normalizedCurrent != "dev" && normalizedLatest != normalizedCurrent`
	`21`	`+ guard !normalizedCurrent.isEmpty && normalizedCurrent != "dev" else { return false }`
	`22`	`+ return normalizedLatest.compare(normalizedCurrent, options: .numeric) == .orderedDescending`
`22`	`23`	`}`
`23`	`24`
`24`	`25`	`var currentVersion: String {`