[Docs] Test helpers: uploadFile helper usage

[tniezurawski]

When you look at README.md you will see at the end of "Test helpers" section line of code with uploadFile helper usage:

uploadFile(content, filename, lastModifiedDate);

Look at the source of test-support/helpers/ember-cli-file-picker.js and createFile function that uses options:

function createFile(content = ['test'], options = {}) {
  const {
    name,
    type,
    lastModifiedDate
  } = options;
...
}

and createFile usage within the helper:

const uploadFile = Ember.Test.registerAsyncHelper('uploadFile', function(app, content, options) {
   const file = createFile(content, options);
...
}

I think that options should be passed as object:

uploadFile(content, {name: filename, type: type, lastModifiedDate: lastModifiedDate});

BTW Please look at Pull Request with very needed changes for test-support/helpers/ember-cli-file-picker.js.

[jelhan]

Also lastModifiedDate is not used. Should be removed from code and docs until someone needs it and implements it. Do you mind providing a PR?

[Ericky14]

The "uploadFileHelper" is not in the docs, does someone know how it is used?

I don't see any internal use of it in the addon and no matter what I do, I'm not able to use it in my own test for some reason. It always says "uploadFileHelper" is not defined.

I need to use that certain function because the file-picker in my page is rendered outside ember-test scope, so the jQuery selector is needed.

Sorry if I shouldn't be posting this here, just thought it had to do with the topic.

[tniezurawski]

@jelhan Yup. I will work on that and make a PR.

@Ericky14 In current implementation... I guess it's unused or I miss something...
It's not defined in your case because if you want to use some helper in tests it needs to be registered the way uploadFile is:

Ember.Test.registerAsyncHelper('uploadFile', function(app, content, options) {});

and uploadFileHelper is not. You should use uploadFile with the changes introduced by @jelhan.

[jelhan]

Use UploadFileHelper for integration tests. There is an example in test suite of this addon.

[fsmanuel]

@jelhan @tniezurawski thx for all the help!

[fsmanuel]

@jelhan @tniezurawski do we have to add an example to the docs?