Lint fixups

Author: adamwight

lib/desktop/menu.ex

@@ -343,18 +343,16 @@ defmodule Desktop.Menu do
 
   @impl true
   def handle_cast({:set_icon, icon}, menu) do
-    with {:ok, menu} <- set_adapter_icon(menu, icon) do
-      {:noreply, menu}
-    else
+    case set_adapter_icon(menu, icon) do
+      {:ok, menu} -> {:noreply, menu}
       _error -> {:noreply, menu}
     end
   end
 
   def handle_cast({:trigger_event, event}, menu = %{module: module}) do
     menu =
-      with {:ok, {:noreply, menu}} <- invoke_module_func(module, :handle_event, [event, menu]) do
-        update_dom(menu)
-      else
+      case invoke_module_func(module, :handle_event, [event, menu]) do
+        {:ok, {:noreply, menu}} -> update_dom(menu)
         _ -> menu
       end
 
@@ -419,9 +417,8 @@ defmodule Desktop.Menu do
   end
 
   defp proxy_handle_info(msg, menu = %Menu{module: module}) do
-    with {:ok, {:noreply, menu}} <- invoke_module_func(module, :handle_info, [msg, menu]) do
-      update_dom(menu)
-    else
+    case invoke_module_func(module, :handle_info, [msg, menu]) do
+      {:ok, {:noreply, menu}} -> update_dom(menu)
       _ -> menu
     end
   end

lib/desktop/menu/adapters/wx.ex

@@ -154,21 +154,21 @@ defmodule Desktop.Menu.Adapter.Wx do
   end
 
   defp create_taskbar_icon(fn_create_popup, icon) do
-    with {:ok, taskbar_icon = %TaskBarIcon{wx_taskbar_icon: wx_taskbar_icon}} <-
-           TaskBarIcon.create(fn_create_popup) do
-      TaskBarIcon.connect(taskbar_icon)
-      TaskBarIcon.set_icon(taskbar_icon, icon)
-
-      if OS.type() == Windows do
-        # This links the taskbar icon and the application itself on Windows
-        if Code.ensure_loaded?(:wxNotificationMessage) &&
-             Kernel.function_exported?(:wxNotificationMessage, :useTaskBarIcon, 1) do
-          :wxNotificationMessage.useTaskBarIcon(wx_taskbar_icon)
+    case TaskBarIcon.create(fn_create_popup) do
+      {:ok, taskbar_icon = %TaskBarIcon{wx_taskbar_icon: wx_taskbar_icon}} ->
+        TaskBarIcon.connect(taskbar_icon)
+        TaskBarIcon.set_icon(taskbar_icon, icon)
+
+        if OS.type() == Windows do
+          # This links the taskbar icon and the application itself on Windows
+          if Code.ensure_loaded?(:wxNotificationMessage) &&
+               Kernel.function_exported?(:wxNotificationMessage, :useTaskBarIcon, 1) do
+            :wxNotificationMessage.useTaskBarIcon(wx_taskbar_icon)
+          end
         end
-      end
 
-      taskbar_icon
-    else
+        taskbar_icon
+
       error ->
         Logger.warning("Failed to create TaskBar Icon: #{inspect(error)}")
         nil

lib/desktop/window.ex

@@ -494,9 +494,7 @@ defmodule Desktop.Window do
     case Enum.find(noties, fn {_, {wx_ref, _callback}} -> wx_ref == obj end) do
       nil ->
         Logger.error(
-          "Received unhandled notification event #{inspect(obj)}: #{inspect(action)} (#{
-            inspect(noties)
-          })"
+          "Received unhandled notification event #{inspect(obj)}: #{inspect(action)} (#{inspect(noties)})"
         )
 
       {_, {_ref, nil}} ->