Skip to content

Commit 817f707

Browse files
committed
Use proper knowledge of connect success/failures in HttpTLSTest for HTTP/3
1 parent 911b2b8 commit 817f707

File tree

1 file changed

+7
-10
lines changed

1 file changed

+7
-10
lines changed

vertx-core/src/test/java/io/vertx/tests/tls/HttpTLSTest.java

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1335,16 +1335,10 @@ TLSTest run(boolean shouldPass) {
13351335
serverBuilder = serverBuilder.with(new OpenSSLEngineOptions());
13361336
}
13371337
test.server = serverBuilder.build();
1338-
AtomicInteger connectedCount = new AtomicInteger();
1339-
// test.server.connectionHandler(conn -> complete());
1340-
AtomicInteger count = new AtomicInteger();
1341-
// test.server.exceptionHandler(err -> {
1342-
// if (!shouldPass) {
1343-
// if (count.incrementAndGet() == 1) {
1344-
// complete();
1345-
// }
1346-
// }
1347-
// });
1338+
AtomicInteger connectSuccess = new AtomicInteger();
1339+
AtomicInteger connectFailures = new AtomicInteger();
1340+
test.server.connectionHandler(conn -> connectSuccess.incrementAndGet());
1341+
test.server.exceptionHandler(err -> connectFailures.incrementAndGet());
13481342
test.server.requestHandler(req -> {
13491343
indicatedServerName = req.connection().indicatedServerName();
13501344
// assertEquals(options.getProtocolVersion(), req.version());
@@ -1404,8 +1398,11 @@ TLSTest run(boolean shouldPass) {
14041398
try {
14051399
fut.await();
14061400
test.assertTrue(shouldPass);
1401+
test.assertTrue(connectSuccess.get() > 0);
1402+
test.assertEquals(0, connectFailures.get());
14071403
} catch (Exception err) {
14081404
test.assertFalse("Should not fail " + err.getMessage(), shouldPass);
1405+
test.assertEquals(0, connectSuccess.get());
14091406
}
14101407
return this;
14111408
}

0 commit comments

Comments
 (0)