Refactor umm dict accessors (#1073)

Author: jhkennedy

earthaccess/results.py

@@ -105,9 +105,7 @@ def get_umm(self, umm_field: str) -> Union[str, Dict[str, Any]]:
         Returns:
             The value of a given field inside the UMM (Unified Metadata Model).
         """
-        if umm_field in self["umm"]:
-            return self["umm"][umm_field]
-        return ""
+        return self["umm"].get(umm_field, "")
 
     def concept_id(self) -> str:
         """Placeholder.
@@ -123,37 +121,27 @@ def data_type(self) -> str:
         Returns:
             The collection data type, i.e. HDF5, CSV etc., if available.
         """
-        if "ArchiveAndDistributionInformation" in self["umm"]:
-            if (
-                "FileDistributionInformation"
-                in self["umm"]["ArchiveAndDistributionInformation"]
-            ):
-                return str(
-                    self["umm"]["ArchiveAndDistributionInformation"][
-                        "FileDistributionInformation"
-                    ]
-                )
-        return ""
+        return str(
+            self["umm"]
+            .get("ArchiveAndDistributionInformation", {})
+            .get("FileDistributionInformation", "")
+        )
 
     def version(self) -> str:
         """Placeholder.
 
         Returns:
             The collection's version.
         """
-        if "Version" in self["umm"]:
-            return self["umm"]["Version"]
-        return ""
+        return self["umm"].get("Version", "")
 
     def abstract(self) -> str:
         """Placeholder.
 
         Returns:
             The abstract of a collection.
         """
-        if "Abstract" in self["umm"]:
-            return self["umm"]["Abstract"]
-        return ""
+        return self["umm"].get("Abstract", "")
 
     def landing_page(self) -> str:
         """Placeholder.
@@ -162,28 +150,23 @@ def landing_page(self) -> str:
             The first landing page for the collection (can be many), if available.
         """
         links = self._filter_related_links("LANDING PAGE")
-        if len(links) > 0:
-            return links[0]
-        return ""
+        return links[0] if len(links) > 0 else ""
 
     def get_data(self) -> List[str]:
         """Placeholder.
 
         Returns:
             The GET DATA links (usually a landing page link, a DAAC portal, or an FTP location).
         """
-        links = self._filter_related_links("GET DATA")
-        return links
+        return self._filter_related_links("GET DATA")
 
     def s3_bucket(self) -> Dict[str, Any]:
         """Placeholder.
 
         Returns:
             The S3 bucket information if the collection has it (**cloud hosted collections only**).
         """
-        if "DirectDistributionInformation" in self["umm"]:
-            return self["umm"]["DirectDistributionInformation"]
-        return {}
+        return self["umm"].get("DirectDistributionInformation", {})
 
     def services(self) -> Dict[Any, List[Dict[str, Any]]]:
         """Return list of services available for this collection."""