Skip to content

Commit dc77742

Browse files
rm logs test for now, can be slow to query (#1153)
the logs test on the cli can just be really slow and time out resulting in false positives; will want to establish faster --limit at some point maybe. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Test-only changes that reduce coverage for `sandbox logs` but do not affect production logic. > > **Overview** > Disables the `sandbox logs` backend integration test in `backend_integration.test.ts` by commenting it out with a note about slow log availability causing timeouts. > > Minor formatting fix in `runCliWithPipedStdin` to correct indentation around the constructed `ETIMEDOUT` error object. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit bbc4720. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 602cc2d commit dc77742

File tree

1 file changed

+17
-16
lines changed

1 file changed

+17
-16
lines changed

packages/cli/tests/commands/sandbox/backend_integration.test.ts

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -97,20 +97,21 @@ describe('sandbox cli backend integration', () => {
9797
}
9898
)
9999

100-
testIf(
101-
'logs returns successfully',
102-
{ timeout: perTestTimeoutMs },
103-
async () => {
104-
const logsResult = runCli([
105-
'sandbox',
106-
'logs',
107-
sandbox.sandboxId,
108-
'--format',
109-
'json',
110-
])
111-
expect(logsResult.status).toBe(0)
112-
}
113-
)
100+
/** Note: removing this test for now because it can be slow to get the logs causing tests to time out */
101+
// testIf(
102+
// 'logs returns successfully',
103+
// { timeout: perTestTimeoutMs },
104+
// async () => {
105+
// const logsResult = runCli([
106+
// 'sandbox',
107+
// 'logs',
108+
// sandbox.sandboxId,
109+
// '--format',
110+
// 'json',
111+
// ])
112+
// expect(logsResult.status).toBe(0)
113+
// }
114+
// )
114115

115116
testIf(
116117
'metrics returns successfully',
@@ -201,8 +202,8 @@ function runCliWithPipedStdin(
201202
clearTimeout(timer)
202203
const timeoutError = timedOut
203204
? Object.assign(new Error('CLI command timed out'), {
204-
code: 'ETIMEDOUT',
205-
} as NodeJS.ErrnoException)
205+
code: 'ETIMEDOUT',
206+
} as NodeJS.ErrnoException)
206207
: undefined
207208
resolve({
208209
status: code,

0 commit comments

Comments
 (0)