Draft
Conversation
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
Contributor
Author
|
/review |
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Assessment: 🔴 CRITICAL
This PR adds a new Django guide to Docker docs. The guide is well-structured and covers a useful topic, but has several issues that need attention before merge:
- 1 HIGH finding: A Compose environment variable (
DEBUG=1) is set butsettings.pyis never shown reading it from the environment, so it silently has no effect. - 3 MEDIUM findings: Non-standard callout syntax, a broken ordered-list code block (missing indentation), and a factually incorrect YAML comment about Django's
DEBUGsetting and auto-reload. - 1 MEDIUM finding: Marketing language ("simplify compliance") in the DHI section.
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added simple Django guide.
Related issues or tickets
Closes #21277
Reviews