Update Dockerfile code snippet for "Using the official Docker image" tab#24820
Update Dockerfile code snippet for "Using the official Docker image" tab#24820craig-osterhout merged 1 commit intodocker:mainfrom
Conversation
The code snippet for Dockerfile under the "Using the official Docker images" contains a comment which says that this Docker file uses DHI image, which is incorrect.
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| # This Dockerfile uses Docker Hardened Images (DHI) for enhanced security. | ||
| # For more information, see https://docs.docker.com/dhi/ | ||
| # This Dockerfile uses Python Docker Official Image | ||
| ARG PYTHON_VERSION=3.12 |
There was a problem hiding this comment.
Did a quick check where this came from, but looks like it landed in the wrong tab when this file was updated; https://github.com/docker/docs/pull/23749/changes#diff-8220f5dd3cc751cccded6014817c5369e9d6bc004ec49478bdab02d0629d3d25R149-R151
|
@dvdksn wondering if we should either adjust the length of the collapsed examples Currently the "preview" only shows comments, and the 
Or perhaps remove the comment about the Dockerfile being ... annotated with comments, which feels a bit self-describing (I guess these were based on the 
|
|
@thaJeztah yes agreed. I mean, taking a step back, I think these guides could be more pedagogical anyway. The purpose of these tutorials (IMHO) is to teach folks how to use Docker, idiomatically with their language/framework. Ie the focus is not getting them through the step-by-step procedure of bootstrapping an application, which is kinda what it feels like now. |
4 participants
The code snippet for Dockerfile under the "Using the official Docker images" contains a comment which says that this Docker file uses DHI image, which is incorrect.
Updated the code snippet to match the tab contents
Reviews