Skip to content

Commit a305fed

Browse files
committed
Catch AttributeError from reverse in check
1 parent b3f943b commit a305fed

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

debug_toolbar/apps.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,9 +251,10 @@ def debug_toolbar_installed_when_running_tests_check(app_configs, **kwargs):
251251
)
252252
try:
253253
# Check if the toolbar's urls are installed
254+
# reverse can raise AttributeError is ROOT_URLCONF is not defined
254255
reverse(f"{APP_NAME}:render_panel")
255256
toolbar_urls_installed = True
256-
except NoReverseMatch:
257+
except (NoReverseMatch, AttributeError):
257258
toolbar_urls_installed = False
258259

259260
# If the user is using the default SHOW_TOOLBAR_CALLBACK,

tests/test_checks.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -304,6 +304,12 @@ def test_debug_toolbar_installed_when_running_tests(self, reverse):
304304
else:
305305
self.assertEqual(len(errors), 0)
306306

307+
@patch("debug_toolbar.apps.reverse")
308+
def test_temp(self, reverse):
309+
reverse.side_effect = AttributeError()
310+
errors = debug_toolbar_installed_when_running_tests_check(None)
311+
assert not errors
312+
307313
@override_settings(
308314
DEBUG_TOOLBAR_CONFIG={
309315
"OBSERVE_REQUEST_CALLBACK": lambda request: False,

0 commit comments

Comments
 (0)