Summary
There is a TODO at kernel/src/checkpoint/tests.rs:761:
// TODO: Add test that checkpoint does not contain tombstoned domain metadata.
The existing test_checkpoint_preserves_domain_metadata test verifies that domain metadata
survives a checkpoint, but there is no test verifying that removed (tombstoned) domain
metadata is excluded from checkpoints.
What to test
- Create a table with the
domainMetadata writer feature
- Add domain metadata for a domain (e.g.
"foo")
- Remove that domain via
with_domain_metadata_removed (this writes a tombstone)
- Write a checkpoint
- Load the snapshot from the checkpoint and verify the removed domain is not present
(get_domain_metadata("foo") returns None)
Relevant code
kernel/src/checkpoint/tests.rs -- existing test_checkpoint_preserves_domain_metadata
kernel/src/transaction/domain_metadata.rs -- generate_user_domain_removal_actions
kernel/src/checkpoint/mod.rs -- checkpoint writing
Summary
There is a TODO at
kernel/src/checkpoint/tests.rs:761:The existing
test_checkpoint_preserves_domain_metadatatest verifies that domain metadatasurvives a checkpoint, but there is no test verifying that removed (tombstoned) domain
metadata is excluded from checkpoints.
What to test
domainMetadatawriter feature"foo")with_domain_metadata_removed(this writes a tombstone)(
get_domain_metadata("foo")returnsNone)Relevant code
kernel/src/checkpoint/tests.rs-- existingtest_checkpoint_preserves_domain_metadatakernel/src/transaction/domain_metadata.rs--generate_user_domain_removal_actionskernel/src/checkpoint/mod.rs-- checkpoint writing