Merge pull request #17 from antedeguemon/vm-fixes-handle-call-warning

Fixes compilation warning from Instance.handle_call/3

Author: danschultzer

.github/workflows/ci.yml

@@ -28,6 +28,7 @@ jobs:
           otp-version: ${{matrix.version.otp}}
           elixir-version: ${{matrix.version.elixir}}
       - run: mix deps.get
+      - run: MIX_ENV=test mix compile --warnings-as-errors
       - run: HTTP_SERVER=${{matrix.http_server}} mix test
       - run: MIX_ENV=test mix credo
   deploy:

CHANGELOG.md

@@ -1,3 +1,10 @@
+# Changelog
+
+## v0.1.14 (TBA)
+
+- Fixed compiler warning in `TestServer.Instance`
+
+
 ## v0.1.13 (2023-08-26)
 
 - Fixed controlling process issues related to using the Bandit HTTP/2 adapter calling `Plug.Conn` functions in plug callbacks

lib/test_server/instance.ex

@@ -213,36 +213,6 @@ defmodule TestServer.Instance do
     {:reply, {:ok, plug}, %{state | plugs: state.plugs ++ [plug]}}
   end
 
-  defp build_match_function(uri, methods) do
-    {method_match, guards} =
-      case methods do
-        ["*"] ->
-          {quote(do: _), true}
-
-        methods ->
-          var = quote do: method
-          guards = quote(do: unquote(var) in unquote(methods))
-
-          {var, guards}
-      end
-
-    {_params, path_match, guards, _post_match} = Plug.Router.Utils.build_path_clause(uri, guards)
-
-    {match_fn, []} =
-      Code.eval_quoted(
-        quote do
-          fn
-            _conn, unquote(method_match), unquote(path_match), _host when unquote(guards) -> true
-            _conn, _method, _path, _host -> false
-          end
-        end
-      )
-
-    fn conn ->
-      match_fn.(conn, conn.method, Plug.Router.Utils.decode_path_info!(conn), conn.host)
-    end
-  end
-
   def handle_call(
         {:register, {:websocket, {_instance, route_ref}, {:handle, options, stacktrace}}},
         _from,
@@ -310,6 +280,36 @@ defmodule TestServer.Instance do
     {:reply, res, state}
   end
 
+  defp build_match_function(uri, methods) do
+    {method_match, guards} =
+      case methods do
+        ["*"] ->
+          {quote(do: _), true}
+
+        methods ->
+          var = quote do: method
+          guards = quote(do: unquote(var) in unquote(methods))
+
+          {var, guards}
+      end
+
+    {_params, path_match, guards, _post_match} = Plug.Router.Utils.build_path_clause(uri, guards)
+
+    {match_fn, []} =
+      Code.eval_quoted(
+        quote do
+          fn
+            _conn, unquote(method_match), unquote(path_match), _host when unquote(guards) -> true
+            _conn, _method, _path, _host -> false
+          end
+        end
+      )
+
+    fn conn ->
+      match_fn.(conn, conn.method, Plug.Router.Utils.decode_path_info!(conn), conn.host)
+    end
+  end
+
   defp run_plugs(conn, state) do
     state.plugs
     |> case do