[UBSAN] Fast sim doing improper cast to RectangularPixelTopology

[Dr15Jones]

The UBSAN build is reporting many errors for workflows 36434.0 and 36834.0 of the type

runtime error: downcast of address 0x1495929a4d00 which does not point to an object of type 'RectangularPixelTopology'

Looking at one in particular seems to readily show the problem

36434.0/step2:FastSimulation/TrackingRecHitProducer/src/PixelTemplateSmearerBase.cc:346:55: runtime error: downcast of address 0x1495929a4d00 which does not point to an object of type 'RectangularPixelTopology'

which points to

cmssw/FastSimulation/TrackingRecHitProducer/src/PixelTemplateSmearerBase.cc

Lines 345 to 346 in 2e9613c

	const PixelTopology* theSpecificTopology = &(detUnit->specificType().specificTopology());
	const RectangularPixelTopology* rectPixelTopology = static_cast<const RectangularPixelTopology*>(theSpecificTopology);

where a static_cast<const RectangularPixelTopology*> which evidently being done on a pointer to an object which is not a RectangularPixelTopology.

[Dr15Jones]

assign FastSimulation/TrackingRecHitProducer

[cmsbuild]

New categories assigned: fastsim

@civanch,@kpedro88,@mdhildreth,@ssekmen you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

cms-bot internal usage

[cmsbuild]

A new Issue was created by @Dr15Jones.

@Dr15Jones, @ftenchini, @makortel, @mandrenguyen, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here