Skip to content

Commit bf057a9

Browse files
author
catlog22
committed
Add quality gates, role library, and templates for team lifecycle v3
- Introduced quality gates documentation outlining scoring dimensions and per-phase criteria. - Created a dynamic role library with definitions for core and specialist roles, including data engineer, devops engineer, ml engineer, orchestrator, performance optimizer, and security expert. - Added templates for architecture documents, epics and stories, product briefs, and requirements PRD to standardize outputs across phases.
1 parent bbdd184 commit bf057a9

65 files changed

Lines changed: 5023 additions & 50 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.claude/skills/team-coordinate/roles/coordinator/role.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ For callback/check/resume/adapt/complete: load `commands/monitor.md` and execute
130130
- Dependency graph: build DAG of work streams
131131
- Complexity scoring: count capabilities, cross-domain factor, parallel tracks
132132
- Role minimization: merge overlapping, absorb trivial, cap at 5
133-
- **Role-spec metadata**: Generate frontmatter fields (prefix, inner_loop, subagents, message_types)
133+
- **Role-spec metadata**: Generate frontmatter fields (prefix, inner_loop, additional_members, message_types)
134134

135135
4. **Output**: Write `<session>/task-analysis.json`
136136

@@ -185,10 +185,10 @@ Regardless of complexity score or role count, coordinator MUST:
185185
5. **Read `specs/role-spec-template.md`** for Behavioral Traits + Reference Patterns
186186

187187
6. **For each role in task-analysis.json#roles**:
188-
- Fill YAML frontmatter: role, prefix, inner_loop, subagents, message_types
188+
- Fill YAML frontmatter: role, prefix, inner_loop, additional_members, message_types
189189
- **Compose Phase 2-4 content** (NOT copy from template):
190190
- Phase 2: Derive input sources and context loading steps from **task description + upstream dependencies**
191-
- Phase 3: Describe **execution goal** (WHAT to achieve) from task description — do NOT prescribe specific subagent or tool
191+
- Phase 3: Describe **execution goal** (WHAT to achieve) from task description — do NOT prescribe specific CLI tool or approach
192192
- Phase 4: Combine **Behavioral Traits** (from template) + **output_type** (from task analysis) to compose verification steps
193193
- Reference Patterns may guide phase structure, but task description determines specific content
194194
- Write generated role-spec to `<session>/role-specs/<role-name>.md`

.claude/skills/team-frontend/role-specs/analyst.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
---
22
prefix: ANALYZE
33
inner_loop: false
4-
additional_members: []
54
message_types:
65
success: analyze_ready
76
error: error

.claude/skills/team-frontend/role-specs/architect.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
---
22
prefix: ARCH
33
inner_loop: false
4-
additional_members: []
54
message_types:
65
success: arch_ready
76
error: error

.claude/skills/team-frontend/role-specs/developer.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
---
22
prefix: DEV
33
inner_loop: true
4-
additional_members: []
54
message_types:
65
success: dev_complete
76
error: error

.claude/skills/team-frontend/role-specs/qa.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
---
22
prefix: QA
33
inner_loop: false
4-
additional_members: []
54
message_types:
65
success: qa_passed
76
error: error

.claude/skills/team-issue/role-specs/explorer.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
---
22
prefix: EXPLORE
33
inner_loop: false
4-
additional_members: []
54
message_types:
65
success: context_ready
76
error: error

.claude/skills/team-issue/role-specs/integrator.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
---
22
prefix: MARSHAL
33
inner_loop: false
4-
additional_members: []
54
message_types:
65
success: queue_ready
76
conflict: conflict_found

.claude/skills/team-issue/role-specs/planner.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
prefix: SOLVE
33
inner_loop: false
44
additional_prefixes: [SOLVE-fix]
5-
additional_members: []
65
message_types:
76
success: solution_ready
87
multi: multi_solution
Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
# Changelog
2+
3+
## v2.1 - Architecture Fix (2026-03-05)
4+
5+
### Fixed
6+
- **Critical**: Removed subagent calls from worker role-specs
7+
- Workers now correctly use CLI tools instead of attempting Agent() spawn
8+
- Removed subagents directory (workers cannot use it)
9+
- Updated SKILL.md to clarify architectural constraints
10+
11+
### Changed
12+
- Multi-perspective critique: Now uses parallel CLI calls
13+
- Codebase exploration: Now uses `ccw cli --tool gemini`
14+
- Document generation: Now uses `ccw cli --tool gemini --mode write`
15+
16+
### Impact
17+
- No functional change for users
18+
- Implementation now architecturally correct
19+
- Workers will no longer fail with "Unknown skill: Agent"
20+
21+
### Files Modified
22+
- `SKILL.md`: Replaced "Subagent Registry" with "CLI Tool Usage in Workers"
23+
- `role-specs/analyst.md`: Removed `subagents: [discuss]`, replaced discuss subagent call with parallel CLI calls
24+
- `role-specs/writer.md`: Removed `subagents: [discuss]`, replaced discuss subagent call with parallel CLI calls
25+
- `role-specs/reviewer.md`: Removed `subagents: [discuss]`, replaced discuss subagent call with parallel CLI calls
26+
- `role-specs/planner.md`: Updated complexity routing table to reference CLI exploration
27+
- `role-specs/architect.md`: Removed `subagents: [explore]`
28+
- `subagents/`: Directory removed
29+
30+
### Technical Details
31+
32+
**Why Workers Cannot Spawn Subagents**:
33+
When a worker attempts `Agent()`, it fails with "Unknown skill: Agent". Only the Coordinator (main conversation context) can spawn agents.
34+
35+
**Worker Capabilities**:
36+
- ✅ Built-in tools: Read, Write, Edit, Bash, Grep, Glob
37+
- ✅ CLI tools: `ccw cli --tool gemini/codex/qwen`
38+
- ❌ Agent spawn: Cannot call `Agent()` to spawn subagents
39+
40+
**Multi-Perspective Critique Implementation**:
41+
Workers now use parallel CLI calls with `run_in_background: true`:
42+
```bash
43+
Bash(`ccw cli -p "..." --tool gemini --mode analysis`, { run_in_background: true })
44+
Bash(`ccw cli -p "..." --tool codex --mode analysis`, { run_in_background: true })
45+
Bash(`ccw cli -p "..." --tool claude --mode analysis`, { run_in_background: true })
46+
```

0 commit comments

Comments
 (0)