Skip to content

Commit 6295796

Browse files
jbachorikclaude
andcommitted
fix(test): resolve duplicate -p flag after rebase onto develop
Rebasing onto develop brought in PR #805's conditional if (btracePort > 0) { add -p btracePort } block, which collides with PR #791's unconditional "-p", String.valueOf(getBTracePort()) in runBTraceDynamic — producing two -p flags when a test overrides btracePort. Keep the unconditional form, since getBTracePort() already honours both the develop-style btracePort field (ExtensionLifecycleIntegrationTest) and the PR-style btrace.port system property (ManifestLibsTests), and drop the now-redundant conditional block. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 3dcea1b commit 6295796

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

integration-tests/src/test/java/tests/RuntimeTest.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1323,10 +1323,6 @@ private Process attach(
13231323
if (unattended) {
13241324
argVals.add("-x");
13251325
}
1326-
if (btracePort > 0) {
1327-
argVals.add("-p");
1328-
argVals.add(String.valueOf(btracePort));
1329-
}
13301326
argVals.addAll(Arrays.asList(pid, traceFile.getAbsolutePath()));
13311327
if (cmdArgs != null) {
13321328
argVals.addAll(Arrays.asList(cmdArgs));

0 commit comments

Comments
 (0)