Merge pull request #29 from DarkHorseComics/ensure-packages

Use ensure_packages to install dependencies

Author: mattheath

README.md

@@ -6,6 +6,7 @@ Requires the following boxen modules:
 
 * `boxen`
 * `homebrew`
+* `stdlib`
 * `wget`
 * `autoconf`
 * `libtool`

manifests/init.pp

@@ -10,6 +10,7 @@
   require php::config
   require homebrew
   include wget
+  include stdlib
   include autoconf
   include libtool
   include pkgconfig
@@ -60,16 +61,7 @@
   }
 
   # Resolve dependencies
-
-  package { [
-      'gmp',
-      'icu4c',
-      'jpeg',
-      'libevent',
-      'mcrypt',
-    ]:
-    provider => homebrew,
-  }
+  ensure_packages( [ 'libevent', 'gmp', 'icu4c', 'jpeg', 'mcrypt', ] )
 
   # Install freetype version 2.4.11 due to conflict with GD
   # See https://github.com/boxen/puppet-php/issues/25

spec/classes/php_spec.rb

@@ -7,6 +7,7 @@
   it do
     should include_class("php::config")
     should include_class("homebrew")
+    should include_class("stdlib")
     should include_class("wget")
     should include_class("autoconf")
     should include_class("libtool")
@@ -63,7 +64,7 @@
       "libevent",
       "mcrypt"
     ].each do |pkg|
-      should contain_package(pkg).with_provider("homebrew")
+      should contain_package(pkg)
     end
 
     should contain_homebrew__formula("autoconf213").with({